Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upisfiletext() checks whether a file is text or binary… #239
Conversation
This comment has been minimized.
This comment has been minimized.
There are failures but they caused by unavailability of libraries, not the new code. MacOS only on Travis, the Linux builds work:trying URL 'https://cloud.r-project.org/src/contrib/data.table_1.12.4.tar.gz'
** package ‘data.table’ successfully unpacked and MD5 sums checked ** using staged installation ** libs clang -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -I/usr/local/include -fopenmp -fPIC -Wall -g -O2 -c assign.c -o assign.o clang: error: unsupported option '-fopenmp' make: *** [assign.o] Error 1 ERROR: compilation failed for package ‘data.table’
Error in i.p(...) : (converted from warning) installation of package ‘data.table’ had non-zero exit status Calls: ... with_rprofile_user -> with_envvar -> force -> force -> i.p Execution halted The command "Rscript -e 'deps <- remotes::dev_package_deps(dependencies = NA);remotes::install_deps(dependencies = TRUE);if (!all(deps$package %in% installed.packages())) { message("missing: ", paste(setdiff(deps$package, installed.packages()), collapse=", ")); q(status = 1, save = "no")}'" failed and exited with 1 during . Your build has been stopped. Appveyor:Packages required but not available: 'haven', 'curl', 'data.table', 'readxl', 'openxlsx', 'tibble' Environment: R_VERSION=release, R_ARCH=x64 and Environment: R_VERSION=oldrel, RTOOLS_VERSION=33, CRAN=http://cran.rstudio.com work fine, the problem is only on Environment: R_VERSION=devel, R_ARCH=x64, GCC_PATH=mingw_64
From this, we know that the file sniffing works on Linux and Windows. MacOS verdict awaiting fix to the problem of |
…test for isfiletext()
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Oct 9, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 86.52% 86.52% +<.01%
==========================================
Files 19 20 +1
Lines 957 965 +8
==========================================
+ Hits 828 835 +7
- Misses 129 130 +1
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Please see #236 (comment) regarding the out-of-date CI failures. Closes #236 |
Generally this looks useful. Some mostly stylistic but a few substantive comments. |
Generally good. Nearly there! |
This comment has been minimized.
This comment has been minimized.
Appveyor timing out on R install step, hopefully temporary problem |
This comment has been minimized.
This comment has been minimized.
Thanks! |
bokov commentedOct 8, 2019
•
edited
…in a cross-platform manner, closing #236. This can be useful when a file extension is missing or ambiguous
Please ensure the following before submitting a PR:
/R
not/man
and rundevtools::document()
to update documentation/tests
for any new functionality or bug fixR CMD check
runs without error before submitting the PR