Permalink
Please
sign in to comment.
Browse files
Point PyYAML dependency to official repository
Previously, PyYAML was hosted on BitBucket, so we had a mirror of the repo on GitHub. Now, official hosting has moved to GitHub, so we can point to the official repository instead. Thanks to Marco A. Feliu <marco.feliu@nianet.org> for pointing this out. This patch also updates the install shim to update submodule URLs. To preserve the functionality of earlier Dotbot versions, we will need to maintain 'https://github.com/anishathalye/pyyaml'. Because old versions of the install shim used with new Dotbot versions will not update submodule URLs, we will need to keep the old repository in sync with the upstream repository as we upgrade PyYAML versions. This patch also upgrades the dependency to PyYAML 3.12.
- Loading branch information...
Showing
with
35 additions
and 10 deletions.
- +1 −1 .gitmodules
- +1 −1 lib/pyyaml
- +1 −2 test/Vagrantfile
- +1 −5 test/test-lib.bash
- +1 −1 test/test_travis
- +29 −0 test/tests/shim.bash
- +1 −0 tools/git-submodule/install
@@ -1,4 +1,4 @@ | ||
[submodule "lib/pyyaml"] | ||
path = lib/pyyaml | ||
url = https://github.com/anishathalye/pyyaml | ||
url = https://github.com/yaml/pyyaml | ||
ignore = dirty |
Submodule pyyaml
updated
from f30c95 to 7e026b
@@ -0,0 +1,29 @@ | ||
test_description='install shim works' | ||
. '../test-lib.bash' | ||
|
||
test_expect_success 'setup' ' | ||
cd ${DOTFILES} | ||
git init | ||
if ${USE_VAGRANT}; then | ||
git submodule add /dotbot dotbot | ||
else | ||
git submodule add ${BASEDIR} dotbot | ||
fi | ||
cp ./dotbot/tools/git-submodule/install . | ||
echo "pear" > ${DOTFILES}/foo | ||
' | ||
|
||
test_expect_success 'run' ' | ||
cat > ${DOTFILES}/install.conf.yaml <<EOF | ||
- link: | ||
~/.foo: foo | ||
EOF | ||
if ! ${USE_VAGRANT}; then | ||
sed -i "" "1 s/sh$/python/" ${DOTFILES}/dotbot/bin/dotbot | ||
fi | ||
${DOTFILES}/install | ||
' | ||
|
||
test_expect_success 'test' ' | ||
grep "pear" ~/.foo | ||
' |
0 comments on commit
7a19cd2