Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new FAQ question on "What if Cloud doesn't do X," Resolves #329 #330

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@ianmilligan1
Copy link
Member

commented Oct 2, 2019

GitHub issue(s):

If you are responding to an issue, please mention their numbers below.

What does this Pull Request do?

Adds a new question and answer in the "data analysis" section. See screenshot:

Screen Shot 2019-10-02 at 2 10 53 PM

How should this be tested?

Beyond usual tests, just reviewing the content.

Interested parties

@ruebot @SamFritz

@ianmilligan1 ianmilligan1 requested review from ruebot and SamFritz Oct 2, 2019
@ruebot
ruebot approved these changes Oct 2, 2019
@codecov

This comment has been minimized.

Copy link

commented Oct 2, 2019

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #330   +/-   ##
======================================
  Coverage    89.4%   89.4%           
======================================
  Files          35      35           
  Lines         623     623           
======================================
  Hits          557     557           
  Misses         66      66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ee8bb...cb5b90e. Read the comment docs.

@ianmilligan1

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

Thanks @ruebot – I'll let you review at your convenience @SamFritz and if it looks good feel free to Squash and Merge. Safe travels today!

Copy link
Member

left a comment

Looks great! Thanks for adding this in @ianmilligan1 - very useful as use cases increase

@ruebot ruebot merged commit 9e76176 into master Oct 3, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 63ee8bb...cb5b90e
Details
codecov/project 89.4% remains the same compared to 63ee8bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruebot ruebot deleted the issue-329 branch Oct 3, 2019
@ruebot

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.