Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v3 API #17

Open
leeper opened this issue Mar 27, 2016 · 19 comments

Comments

@leeper
Copy link
Member

commented Mar 27, 2016

API v2 is being discontinued. This will need to be rewritten using the v3 API (https://developer.surveymonkey.com/api/v3). I do not have time to do this, so the package has been archived on CRAN. Please consider this an open call for help in getting the package working with the new API.

@seanofahey

This comment has been minimized.

Copy link

commented Dec 27, 2016

I forked the project and started work on the upgrade of to V3 here https://github.com/seanofahey/Rmonkey. All help is welcome

@leeper

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2016

If you would like, I can give you write permission here so that you can directly push updates. Interested?

@leeper

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2017

@seanofahey Would you be interested in becoming maintainer of this package?

@seanofahey

This comment has been minimized.

Copy link

commented Jan 10, 2017

@leeper

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2017

Basically, just keep doing what you're doing, but also send updates to CRAN (if you want). You would have write permission on the repository so you can make all changes here directly.

@sfirke

This comment has been minimized.

Copy link

commented Mar 30, 2017

I am able to get my data out of SurveyMonkey using @seanofahey's fork 👍 So it feels like this is almost there.

Results-wise, some to-do enhancements I see there are (a) assign legal variable names to the columns and store the question text in an attribute and (b) ideally, retain ordered factor info for questions where that's applicable.

User-friendliness-wise, the README should be updated to address the new function workflow for getting data out. Some README content can come from the RMonkey Demo.R file but I don't think the new retrieval code is there. This would be best be written by @seanofahey since I've only stumbled into something that works but don't understand the organization of the functions. But, if that doesn't happen, I may write up what works for me, so my colleagues can use this.

@seanofahey

This comment has been minimized.

Copy link

commented Mar 31, 2017

@sfirke Thanks for the suggestions. I'll update the README content to sync it with what is available now and then get back to completing the remaining functions.

@sfirke

This comment has been minimized.

Copy link

commented Mar 31, 2017

@seanofahey I've made some developments on my fork of your fork, https://github.com/sfirke/Rmonkey.

Among other things:

  • renamed some functions slightly (taking the style in a tidyverse direction)
  • updated the README (and did it in .Rmd)
  • added a function to get an sm_survey from the survey_list by name, vs. by subsetting on index number
  • the resulting data.frame with the survey data has sequenced variable names in the style of what SurveyMonkey gives you in an SPSS export (names are q1, q2, q3_1, q3_2, etc.) and the question text is stored as a label attribute on each column.

I opened and closed some issues on my fork too if you want to see what I have planned. I haven't touched any survey creation or modification functionality, those are low priority for me.

Let me know if/how you'd like to collaborate; I wanted to move on this so I could use it today but don't want to duplicate any work going forward.

@seanofahey

This comment has been minimized.

Copy link

commented Mar 31, 2017

@sfirke I updated the README file on my fork to more clearly explain the functions in use in the RMonkey Demo.R file. Let's sync tomorrow and we can plan the road ahead.

@ClimateNexus

This comment has been minimized.

Copy link

commented Aug 17, 2017

Hey guys, thanks to @seanofahey for upgrading to v3.

Just wanted to say that for large survey downloads (N-sizes larger than 2,000) it's really slow due to the for/repeat loops. After benchmarking, I replaced the loops with purrr::map() and it's hundreds of times faster. 2,500 respondents can be downloaded, filtered, and merged in under 5 minutes using map(). Just wanted to let you guys know incase you're looking to make it faster. Best!

@sfirke

This comment has been minimized.

Copy link

commented Aug 17, 2017

@ClimateNexus I would love to see that - do you have it somewhere you could share?

@seanofahey

This comment has been minimized.

Copy link

commented Aug 18, 2017

@sfirke

This comment has been minimized.

Copy link

commented Jan 26, 2018

@ClimateNexus could you post your updates to this package in a GitHub repo?

@davidski

This comment has been minimized.

Copy link

commented Apr 24, 2019

The PR for API v3 compatibility is pretty stale. I may need to work with SurveyMonkey in the near future and would like to have a clean interface. Are there cycles available from any maintainers to review a fresh PR in the coming weeks should this motivate me enough to contribute some bits? 😁

@leeper

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

I'm no longer maintaining this package. If someone wants to work on it, I'm happy to grant edit rights.

@davidski

This comment has been minimized.

Copy link

commented Apr 24, 2019

Thanks, @leeper! Let me see if this project materializes to give me the needed drive to dive into this. If so, I'll reach back out to you. Thanks for all the work on this!

@seanofahey

This comment has been minimized.

Copy link

commented Apr 26, 2019

@sfirke

This comment has been minimized.

Copy link

commented Oct 3, 2019

To anyone watching this, I built on the 2016 Rmonkey code (v 0.3.3) and rewrote the putting-the-result-in-a-tidy-data.frame part. The new package is here: https://github.com/tntp/surveymonkey It's still a work in progress but should work for most cases. I'd be eager to hear from users/devs here if you have feedback, find bugs, or can contribute to improving the code.

If it appears satisfactory I could probably clean it up and send it toward CRAN.

@leeper

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

@sfirke I’m also happy to have you migrate that code to this repo, if you want. Will gladly give you edit rights if you’re interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.