Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: simode: R Package for Statistical Inference of Ordinary Differential Equations using Separable Integral-Matching #1772

Open
whedon opened this issue Sep 29, 2019 · 30 comments

Comments

@whedon
Copy link
Collaborator

commented Sep 29, 2019

Submitting author: @ramiyaari (Rami Yaari)
Repository: https://github.com/ramiyaari/simode/
Version: v1.1.6
Editor: Pending
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @ramiyaari. Currently, there isn't an JOSS editor assigned to your paper.

@ramiyaari if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Sep 29, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 29, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 29, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon whedon added HTML R TeX labels Sep 29, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 29, 2019

Failed to discover a valid open source license.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 29, 2019

PDF failed to compile for issue #1772 with the following error:

Could not find bibliography file: simode.bib
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@danielskatz

This comment has been minimized.

Copy link

commented Sep 29, 2019

@ramiyaari - I see some high-level issues here:

  • no readme
  • no license

Please see https://joss.readthedocs.io/en/latest/submitting.html#typical-paper-submission-flow

Also, in your paper, you say the bib is "bibliography: simode.bib" but it's actually "paper.bib" - please fix this, then enter @whedon generate pdf as a new comment in this issue to recompile.

@ramiyaari

This comment has been minimized.

Copy link

commented Sep 30, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

PDF failed to compile for issue #1772 with the following error:

Error producing PDF.
! LaTeX Error: Bad math environment delimiter.

See the LaTeX manual or LaTeX Companion for explanation.
Type H for immediate help.
...

l.466 \begin{equation}

Looks like we failed to compile the PDF

@ramiyaari

This comment has been minimized.

Copy link

commented Sep 30, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

PDF failed to compile for issue #1772 with the following error:

Error producing PDF.
! Missing \endgroup inserted.

\endgroup
l.482 \begin{eqnarray}

Looks like we failed to compile the PDF

@ramiyaari

This comment has been minimized.

Copy link

commented Sep 30, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

@ramiyaari

This comment has been minimized.

Copy link

commented Sep 30, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

@ramiyaari

This comment has been minimized.

Copy link

commented Sep 30, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

@ramiyaari

This comment has been minimized.

Copy link

commented Sep 30, 2019

@danielskatz thanks for your comments
I believe I fixed all these issues

@ramiyaari

This comment has been minimized.

Copy link

commented Sep 30, 2019

@whedon commands

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

@ramiyaari

This comment has been minimized.

Copy link

commented Sep 30, 2019

Please update the software version to 1.1.6
Suggested Reviewers: Jgoldfar, trashbirdecology, MikeLydeamore, MaaniBeigy, llauriciu, matloff, ellessenne, osorensen, RomainAzais

@danielskatz

This comment has been minimized.

Copy link

commented Sep 30, 2019

@whedon set v1.1.6 as version

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2019

OK. v1.1.6 is the version.

@danielskatz

This comment has been minimized.

Copy link

commented Sep 30, 2019

I still don't see a readme or a license in the source repo.

@ramiyaari

This comment has been minimized.

Copy link

commented Oct 1, 2019

There is a README.txt and a LICENSE.txt file under inst/joss in the repo, together with paper.md

@ramiyaari

This comment has been minimized.

Copy link

commented Oct 3, 2019

@danielskatz: There is a README.txt and a LICENSE.txt file under inst/joss in the repo, together with paper.md

@danielskatz

This comment has been minimized.

Copy link

commented Oct 4, 2019

These need to be at the top level of the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.