Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ESlint for project; resolves #89. #97

Merged
merged 2 commits into from Apr 9, 2018

Conversation

@ruebot
Copy link
Member

commented Apr 8, 2018

  • Add ESlint config
  • Update gitignore
  • Update TravisCI config
  • Add Rake task
  • Clean-up JS files
  • Ignore some JS files

I've tested locally by moving the gexf file, and also removing all the nodes and edges to simulate an empty graph so recreate the two conditionals. Everything looks fine, but just want to make sure things are good not on my laptop.

@greebie and @ianmilligan1 would you mind doing a smoke test on your end?

- Add ESlint config
- Update gitignore
- Update TravisCI config
- Add Rake task
- Clean-up JS files
- Ignore some JS files
@ruebot

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2018

Oh yeah, TravisCI runs the ESlinting now too, so that should be good too.

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2018

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files          26       26           
  Lines         239      239           
=======================================
  Hits          208      208           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6e5be...761388a. Read the comment docs.

Copy link
Member

left a comment

Tested – both successfully with everything, and also successfully caught that files were missing when they were removed.

@ruebot ruebot changed the title Setup ESlint to project; resolves #89. Setup ESlint for project; resolves #89. Apr 9, 2018
@ruebot ruebot requested a review from greebie Apr 9, 2018
{
"extends": "airbnb-base/legacy",
"globals": {
"jQuery": true,

This comment has been minimized.

Copy link
@greebie

greebie Apr 9, 2018

Contributor

add sigma as a global?

@greebie

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2018

lgtm. Only comment is the optional add of sigma to the globals list.

@greebie
greebie approved these changes Apr 9, 2018
@ianmilligan1 ianmilligan1 merged commit d15b88b into master Apr 9, 2018
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing cc6e5be...761388a
Details
codecov/project 87.02% remains the same compared to cc6e5be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ruebot ruebot deleted the eslint branch Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.