Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More type fixes #3409

Merged
merged 4 commits into from Mar 31, 2018
+100 −88

Conversation

@customcommander
Copy link
Contributor

commented Mar 29, 2018

Fixes a few additional issues mentioned in #3407

<if variable="URL" type="webpage post-weblog">
<if type="legislation bill"/>
<if is-numeric="edition" type="book article"/>

I also took the liberty of cleaning up redundant whitespaces in some type attributes values.

Fixes are grouped in separate commits to make it easier to review and/or revert.

Let me know if that works @adam3smith
@customcommander
sodertorns-hogskola-harvard-ibid (+ibid): nest conditions as otherwis… 
…e they would never work
a81ef80
@customcommander
university-college-lillebaelt-vancouver.csl: set match to any as othe… 
…rwise it will never match
68975da
@customcommander
uppsala-universitet-historia.csl: nest conditions as otherwise they w… 
…ould never work
db69372
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 29, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 29, 2018

😃 Your submission passed all our automated tests.

@customcommander customcommander force-pushed the customcommander:more-type-fixes branch from f2cb878 to 2610c4b Mar 29, 2018

@customcommander
tidy up: remove redundant whitespaces in type attribute value
Loading status checks…
2610c4b
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 29, 2018

😃 Your submission passed all our automated tests.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 31, 2018

Great, thanks!

@adam3smith adam3smith merged commit 5ef8d92 into citation-style-language:master Mar 31, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@customcommander @csl-bot @adam3smith
You can’t perform that action at this time.