Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Chicago Figures code #2220

Merged
merged 2 commits into from Oct 8, 2016

Conversation

@rmzelle
Copy link
Member

commented Sep 12, 2016

Reorganize code a little in response to #2196.

Better use of cs:choose, groups, and the style will now print at least something for most item types.

@csl-bot

This comment has been minimized.

Copy link

commented Sep 12, 2016

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

commented Sep 12, 2016

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2016

Not fully tested, since the current stable version of Zotero has a citation bug that affects this particular style. Should be fixed in the next release (https://forums.zotero.org/discussion/62288/citeproc-js-bug), at which point I'll revisit this and merge.

@csl-bot

This comment has been minimized.

Copy link

commented Oct 8, 2016

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 1910733 into master Oct 8, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rmzelle rmzelle deleted the chicago-figures branch Oct 8, 2016

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2016

Looks good in Zotero 4.0.29.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.