Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from "http" to "https" for DOI links #2241

Merged
merged 1 commit into from Sep 28, 2016

Conversation

@rmzelle
Copy link
Member

commented Sep 27, 2016

Per #2197

@csl-bot

This comment has been minimized.

Copy link

commented Sep 27, 2016

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@rmzelle

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2016

@adam3smith, feel free to merge. Simple find-and-replace of "http://doi.org/" by "https://doi.org/".

(I noticed that association-for-computing-machinery.csl at https://github.com/citation-style-language/styles/pull/2241/files#diff-15aaee93c6e5331268bb6e7773a9f146R99 is a bit funky with prefix=" DOI:https://doi.org/"; haven't checked if they actually require that)

@csl-bot

This comment has been minimized.

Copy link

commented Sep 27, 2016

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 6eeb73a into master Sep 28, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Sep 28, 2016

cool, thanks

@rmzelle rmzelle deleted the doi-https branch Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.