Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create iranian-journal-of-pharmaceutical-research.csl #3279

Merged
merged 6 commits into from Mar 15, 2018

Conversation

@POBrien333
Copy link
Contributor

commented Jan 21, 2018

@csl-bot

This comment has been minimized.

Copy link

commented Jan 21, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Jan 21, 2018

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jan 21, 2018

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Jan 24, 2018

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Jan 31, 2018

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Jan 31, 2018

😃 Your submission passed all our automated tests.

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2018

Heya @rmzelle and @adam3smith . Could you review this one? There is another style in the pipeline that I want to base on this one once it's been reviewed. Cheers :)

@adam3smith

This comment has been minimized.

Copy link
Member

commented Feb 7, 2018

Sorry for the delay. I still have some concern about how online articles are displayed. The guidelines have
Morse SS. Factors in the Emergence of Infectious Diseases. Emerg. Infect. Dis. [serial online] 1995 Jan-Mar [cited 1996 Jun 5], 1: [24 screens]. Available from: URL: http://www.cdc.gov/ncidod/EID/eid.htm.

and I don't think the current style is getting that quite right yet. I fixed some things a week ago, but I don't think it's quite there yet. If you can take another look, that'd be great; otherwise I'll try to get to it asap.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Feb 8, 2018

(style metadata looks good)

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2018

Adam,
That online article example is such a weird one. 1 is the issue, and 24 the volume. What's the "screens" meant to mean? also "available from: URL:..." Very odd.

Btw. Why is the notifications on GitHub gone?

@rmzelle

This comment has been minimized.

Copy link
Member

commented Feb 13, 2018

Adam,
That online article example is such a weird one. 1 is the issue, and 24 the volume. What's the "screens" meant to mean? also "available from: URL:..." Very odd.

It's this article: https://dx.doi.org/10.3201/eid0101.950102. It says "Volume 1, Number 1". My guess is that "24 screens" is the number of paper pages if you print out the online article (which is not very useful or reproducible information, but that's the only thing that I can come up with).

Btw. Why is the notifications on GitHub gone?

@POBrien333, they work for me. You're not getting any? Or are you missing a particular type of notifications?

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2018

Hmm. The whole little notification blob on the top right beside my profile has been gone for weeks now. Just played around with some settings. I've just assumed it was something with GitHub (or my browser, but the same in all of them, so it must be the settings if it works for you).

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2018

Notifications are back now. Had to activate them all... I wonder why they were shut off in the first place.
thanks :)

@csl-bot

This comment has been minimized.

Copy link

commented Mar 15, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 2b18af6 into citation-style-language:master Mar 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Mar 15, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.