Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-cardiff-university.csl #3676

Merged
merged 3 commits into from Sep 13, 2018

Conversation

@YoungZoe
Copy link
Contributor

commented Sep 5, 2018

Disambiguation wasn't working correctly as it should use letters after the year rather than including more names.

Update harvard-cardiff-university.csl
Disambiguation wasn't working correctly as it should use letters after the year rather than including more names.
@csl-bot

This comment has been minimized.

Copy link

commented Sep 5, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Sep 5, 2018

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

@YoungZoe, thanks. Do you know if this is discussed in the style guide somewhere?

@csl-bot

This comment has been minimized.

Copy link

commented Sep 6, 2018

😃 Your submission passed all our automated tests.

@YoungZoe

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2018

@adam3smith

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

right, but your changes don't affect citations by the same author(s). They're only relevant where

  1. different authors with the same last name are cited (add-givenname)
  2. the first author is the same but not the whole set of authors (add-names)

The passage you cite is silent on this as far as I can tell.

@YoungZoe

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2018

@rmzelle

This comment has been minimized.

Copy link
Member

commented Sep 8, 2018

@YoungZoe, thanks for clarifying. Would it be possible for you to attach the guide to a new comment here? You need to use the GitHub website for that (via simple drag and drop), email attachments aren't saved.

@adam3smith adam3smith added the waiting label Sep 10, 2018

@YoungZoe

This comment has been minimized.

@adam3smith adam3smith removed the waiting label Sep 13, 2018

@csl-bot

This comment has been minimized.

Copy link

commented Sep 13, 2018

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

I'll note that the passage of the guide you quote is still entirely ambiguous/silent on how citations by different author groups with the same first author should be disambiguated, or how citations by authors with the same last name but different first names should be disambiguated. I understand, though, that you're in charge of the style guide, so we'll take your word for it (but you may want to clarify this in future editions).

@adam3smith adam3smith merged commit a777986 into citation-style-language:master Sep 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.