Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create infomin #3966

Merged
merged 4 commits into from Apr 20, 2019

Conversation

@rcervantesb
Copy link
Contributor

commented Mar 3, 2019

No description provided.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 3, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 3, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 4, 2019

😟 There are some issues with your submission. Please check the test report for details.

Delete unused macros
use right version of CC license
@csl-bot

This comment has been minimized.

Copy link

commented Mar 5, 2019

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

left a comment

A bunch of comments in-line. Please apply equally to your other submission.

infomin.csl Outdated Show resolved Hide resolved
infomin.csl Outdated
<substitute>
<names variable="editor">
<name and="symbol" name-as-sort-order="all" sort-separator=", " initialize-with=". " delimiter="; " delimiter-precedes-last="never"/>
<label form="short" prefix=" (" suffix=")."/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 5, 2019

Member

add the label just like this to the author (where it's empty), then use just <names variable="editor"/> (and translator, interviewer, container-author) in substitute.

infomin.csl Outdated
<text variable="title" prefix=". " font-style="italic"/>
</if>
<else-if type="article-journal article-magazine article-newspaper chapter entry-encyclopedia entry entry-dictionary paper-conference post-weblog" match="any">
<text variable="title" suffix="" prefix=". “"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 5, 2019

Member

You'll want to use quotes="true" for that and write the quotes into the terms section

infomin.csl Outdated
</choose>
</macro>
<macro name="number-of-pages">
<text variable="number-of-pages"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 5, 2019

Member

you'll want all of the term+variable combination in a group so that the term doesn't get printed if the variable isn't present.

infomin.csl Outdated
<macro name="container-title">
<text variable="container-title" font-style="italic"/>
</macro>
<macro name="responsability">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 5, 2019

Member

should be "responsiblility" (obviously the code doesn't care about the typo, but makes it harder to fix).

infomin.csl Outdated
<text variable="container-title" font-style="italic"/>
</macro>
<macro name="responsability">
<choose>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 5, 2019

Member

No need for this choose/if here. The group takes care of that.

@stale

This comment has been minimized.

Copy link

commented Apr 4, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Apr 4, 2019

@stale stale bot closed this Apr 18, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Leaving this open

@adam3smith adam3smith reopened this Apr 19, 2019

@stale stale bot removed the waiting label Apr 19, 2019

@csl-bot

This comment has been minimized.

Copy link

commented Apr 19, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 20, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit f4608c9 into citation-style-language:master Apr 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Gracias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.