Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create civitas-journal-of-social-sciences-abnt.csl #3983

Merged
merged 9 commits into from Apr 18, 2019

Conversation

@CivitasBR
Copy link
Contributor

commented Mar 12, 2019

Adapting the Brazilian reference norm ABNT 6023 to Civitas journal. Main change is abolishing uppercase by family names. Further changes: using the sequence given name family name for editors and secondary contributors as well as dropping parts of "issued" information.

Create civitas-journal-of-social-sciences-abnt.csl
Adapting the Brazilian reference norm ABNT 6023 to Civitas journal. Main change is abolishing uppercase by family names.
@csl-bot

This comment has been minimized.

Copy link

commented Mar 12, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Mar 12, 2019

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

left a comment

Some requested changes, some questions. Thanks!

<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="in-text" demote-non-dropping-particle="never">
<info>
<title>Civitas: Journal of Social Sciences - Abnt</title>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

I don't think we'll want to include ABNT in the title (filename, id, link) for the style. It's just the style for a journal which is a slight variant on a standard.

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

You are right, no need for it.

<macro name="container-contributors">
<choose>
<if type="chapter entry-dictionary" match="any">
<text value="In: "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

us <text term="in" suffix=": " text-case="capitalize-first"/> so that this will also work in Spanish (i.e. produce "En: ")

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

I was not sure how to solve it (my "model" was only for pt-BR). Thank you.

<text value="In: "/>
<names variable="container-author" delimiter=", ">
<name delimiter="; " delimiter-precedes-last="always">
<name-part name="family" text-case="capitalize-first"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

I'm a little confused why you're removing the all-caps when the journal styleguide has them for all creators. But if you do want to remove them, there's no need for any of the <name-part lines. You can just delete them and put the / at the end of the <name line.

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

The Editorial Board wants to change this particular format for 2020. New submissions should be already adapted for it. The "name-part" is being suppressed.

<name-part name="given" text-case="capitalize-first"/>
</name>
<et-al font-style="italic"/>
<label form="short" prefix=" (" suffix=".). "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

no need for the first . in the suffix (all short forms include periods)

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

Ok thank you for the information

<if type="chapter entry-dictionary" match="none">
<names variable="editor" delimiter=", " prefix=" (" suffix=")">
<name and="symbol" delimiter=", "/>
<label form="short" prefix=", " text-case="capitalize-first" suffix="."/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

ditto here, remove . in suffix. (and so on as the style continues)

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

Done.

</choose>
</macro>
<macro name="archive">
<group>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

no need for the group here

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

Removed.

</group>
</macro>
<macro name="number">
<group>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

No need for the group here either

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

Also removed.

<text macro="number" suffix=". "/>
<text macro="title" suffix=". "/>
<text variable="references" suffix=", " font-weight="bold"/>
<text variable="note"/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

I'd prefer this without note -- what's the goal here?

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

It was an "unnecessary leftover" of the model I used. Removed.

<text macro="author" suffix=". "/>
<text macro="title" suffix=", "/>
<text macro="issued-year" suffix=". "/>
<text variable="note" suffix=". "/>

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

ditto on note.

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

Removed.

<text variable="collection-title" suffix=". "/>
<text macro="translator" suffix=". "/>
<text macro="edition" suffix=". "/>
<group suffix=". ">

This comment has been minimized.

Copy link
@adam3smith

adam3smith Mar 23, 2019

Member

probably safer to set the suffix on locators in case they don't exists (because then you'd get duplicate ". . " with this)

This comment has been minimized.

Copy link
@CivitasBR

CivitasBR Apr 6, 2019

Author Contributor

Thanks for the indication. I made changes and then a lot of tests. It seems that I managed to prevent the duplicate ".." occurrence.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 6, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 6, 2019

😃 Your submission passed all our automated tests.

Update civitas-journal-of-social-sciences-abnt.csl
Including small corrections like: no duplication of "pp" for pages; to avoid italic for "et al."; dito for quotes on journal articles titles; including term for "no date".
@csl-bot

This comment has been minimized.

Copy link

commented Apr 14, 2019

😃 Your submission passed all our automated tests.

Update civitas-journal-of-social-sciences-abnt.csl
The editors are planning to change family-names from "uppercase" to "capitalize-first". I have include the new format in the first version of the style. Now the option is to maintain "uppercase" while format change is not implemented. Also 'delimiter-precedes-et-al="never"' was included here. In Social Sciences this is not necessary for the other "contributors".
I simplified the cases for "author" (no more "if-cases").
"Entry-encyclopedia" became part of "locators".
In bibliography I have included "speech", the variable "genre" for "manuscripts", and I replaced "entry-encyclopedia" (putting together with "chapter" etc.).
@csl-bot

This comment has been minimized.

Copy link

commented Apr 15, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 16, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

(@adam3smith, good to merge from my side, although we often drop subtitles for CSL style titles and IDs, and for a Brazilian journal the Portuguese subtitle might make more sense ("Civitas - Revista de Ciências Sociais"))

@CivitasBR

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

If I understood correctly, your suggestion is to change from:
<title>Civitas: Journal of Social Sciences</title>
to
<title>Civitas: Revista de Ciências Sociais</title>
I agree with the suggestion. Should I change it or could it be done by a volunteer just before merging the style?

@adam3smith

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

I'll handle the rename before merging - thanks!

Update civitas-journal-of-social-sciences.csl
You are right. I need a "suffix" after "issued-year".
On type="report" (line 432) I excluded a dot and included suffix=" " (line 433).
@csl-bot

This comment has been minimized.

Copy link

commented Apr 17, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 18, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Apr 18, 2019

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 6889da6 into citation-style-language:master Apr 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.