Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bluebook-law-review.csl #4114

Merged
merged 2 commits into from Jun 21, 2019

Conversation

@fettingderek
Copy link
Contributor

commented May 23, 2019

Fixed else clause in source macro.

Update bluebook-law-review.csl
Fixed else clause in source macro.
@csl-bot

This comment has been minimized.

Copy link

commented May 23, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented May 23, 2019

😃 Your submission passed all our automated tests.

@mattluce

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Can this be merged?

@fettingderek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Can this be merged please?

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

Sorry this took so long.
I agree with the switch to italics, but I'm not sure moving volume to the back is right. My understanding of BB citations for books (which presumably is the most important category in else is that they should begin with the volume?

Update bluebook-law-review.csl
Added volume to be before authors for books
Added new if clause for books in source macro (removed volume)
@fettingderek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

Hello,
I've updated the style to display volume ahead of authors for books (instead of in the source macro), and to make book titles small caps.

@csl-bot

This comment has been minimized.

Copy link

commented Jun 17, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Great, thanks!

@adam3smith adam3smith merged commit 9bfcdfd into citation-style-language:master Jun 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.