Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buletin-Agrohorti.csl #4185

Merged
merged 7 commits into from Jul 14, 2019

Conversation

@tosptommy
Copy link
Contributor

commented Jul 9, 2019

This is a citation style for Buletin Agrohorti, which is the academic journal from Agronomy and Horticulture Department, Faculty of Agriculture, IPB University, Bogor, Indonesia. The journal can be found in journal.ipb.ac.id/index.php/bulagron/index .

Buletin-Agrohorti.csl
This is a citation style for Buletin Agrohorti, which is the academic journal from Agronomy and Horticulture Department, Faculty of Agriculture, IPB University, Bogor, Indonesia.
@csl-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

😟 There are some issues with your submission.

5 tests failed

Buletin-Agrohorti: must have a conventional file name

expected "Buletin-Agrohorti.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"Buletin-Agrohorti.csl"

Buletin-Agrohorti: must have a "self" link

expected #has_self_link? to return true, got false

Buletin-Agrohorti: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/Buletin-Agrohorti"
     got: "http://csl.mendeley.com/styles/543704551/bulagron"

(compared using ==)

Buletin-Agrohorti: must have the correct Creative Commons BY-SA license text

expected: "This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License"
     got: "\nThis work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License\n"

(compared using ==)

Diff:
@@ -1,2 +1,3 @@
+
 This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License

Buletin-Agrohorti: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (3) and et-al-use-first () to be of same type

Please check the test report for details.

rmzelle added 2 commits Jul 9, 2019
@csl-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

😟 There are some issues with your submission.

5 tests failed

Buletin-Agrohorti: must have a conventional file name

expected "Buletin-Agrohorti.csl" to match /^[a-z\d]+(-[a-z\d]+)*\.csl$/
Diff:
@@ -1,2 +1,2 @@
-/^[a-z\d]+(-[a-z\d]+)*\.csl$/
+"Buletin-Agrohorti.csl"

Buletin-Agrohorti: must have a "self" link

expected #has_self_link? to return true, got false

Buletin-Agrohorti: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/Buletin-Agrohorti"
     got: "http://csl.mendeley.com/styles/543704551/bulagron"

(compared using ==)

Buletin-Agrohorti: must have the correct Creative Commons BY-SA license text

expected: "This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License"
     got: "\nThis work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License\n"

(compared using ==)

Diff:
@@ -1,2 +1,3 @@
+
 This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License

Buletin-Agrohorti: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (3) and et-al-use-first () to be of same type

Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

😟 There are some issues with your submission.

1 test failed

buletin-agrohorti: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (3) and et-al-use-first () to be of same type

Please check the test report for details.

@rmzelle

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@tosptommy, thanks. Did you start from an existing CSL style, and if so, do you remember which one? We try to add a "template" link to any derived CSL style (see also https://github.com/citation-style-language/styles/wiki/Style-Requirements#8---template-link).

@csl-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

buletin-agrohorti.csl (new)
(Hancké, … Thatcher, 2007; 2012)
(Mares, 2001; Fenner, … Clark, 2019)

2012. CSL search by example. Citation Style Editor. Available at http://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012.
2007. Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy (B. Hancké, M. Rhodes, and M. Thatcher (eds.). Oxford University Press, Oxford and New York, pp.
Fenner, M., M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers?; pp. 184–213 in P. A. Hall and D. Soskice (eds.), Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York.
@csl-bot

This comment has been minimized.

Copy link

commented Jul 14, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

buletin-agrohorti.csl (new)
(Hancké et al., 2007; 2012)
(Mares, 2001; Fenner et al., 2019)

2012. CSL search by example. Citation Style Editor. Available at http://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012.
Fenner, M, M Crosas, JS Grethe, D Kennedy, H Hermjakob, P Rocca-Serra, G Durand, R Berjon, S Karcher, M Martone, T Clark. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.
Hancké, B, M Rhodes, M Thatcher, editors. 2007. Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, Oxford and New York, pp.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In PA Hall, D Soskice (eds.). Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York. 184–213.
@csl-bot

This comment has been minimized.

Copy link

commented Jul 14, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

buletin-agrohorti.csl (new)
(Hancké et al., 2007; 2012)
(Mares, 2001; Fenner et al., 2019)

2012. CSL search by example. Citation Style Editor. Available at http://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012.
Fenner, M, M Crosas, JS Grethe, D Kennedy, H Hermjakob, P Rocca-Serra, G Durand, R Berjon, S Karcher, M Martone, T Clark. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.
Hancké, B, M Rhodes, M Thatcher, editors. 2007. Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, Oxford and New York, pp.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In PA Hall, D Soskice (eds.). Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York. 184–213.
@csl-bot

This comment has been minimized.

Copy link

commented Jul 14, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

buletin-agrohorti.csl (new)
(Hancké et al., 2007; 2012)
(Mares, 2001; Fenner et al., 2019)

2012. CSL search by example. Citation Style Editor. Available at http://editor.citationstyles.org/searchByExample/. Accessed December 15, 2012.
Fenner, M., M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6:28.
Hancké, B., M. Rhodes, M. Thatcher, editors. 2007. Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, Oxford and New York, pp.
Mares, I. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In P.A. Hall, D. Soskice (eds.). Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Oxford University Press, New York. 184–213.

@adam3smith adam3smith merged commit edb7d20 into citation-style-language:master Jul 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.