Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-university-of-technology-sydney.csl #4229

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@MeijunHuang
Copy link
Contributor

commented Jul 30, 2019

No description provided.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Jul 30, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

harvard-university-of-technology-sydney.csl (modified style; unchanged output for sample items)
(“CSL search by example” 2012; Hancké, Rhodes & Thatcher 2007)
(Fenner et al. 2019; Mares 2001)

“CSL search by example” 2012, Citation Style Editor, viewed 15 December 2012, <http://editor.citationstyles.org/searchByExample/>
Fenner, M., Crosas, M., Grethe, J.S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M. & Clark, T. 2019, “A data citation roadmap for scholarly data repositories,” Scientific Data, vol. 6, no. 1, p. 28, viewed 27 April 2019, <http://www.nature.com/articles/s41597-019-0031-8>
Hancké, B., Rhodes, M. & Thatcher, M. (eds) 2007, Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York.
Mares, I. 2001, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in P.A. Hall & D. Soskice (eds),Varieties of capitalism. The institutional foundations of comparative advantage, Oxford University Press, New York, pp. 184–213.
@MeijunHuang

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@rmzelle rmzelle merged commit 2214111 into citation-style-language:master Jul 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

The style I proposed only has single quotation marks. Could you help check about this?

In Zotero I get the following output with single quotes:

Abbott, D.A., van den Brink, J., Minneboo, I.M.K., Pronk, J.T. & van Maris, A.J.A. 2009, ‘Anaerobic homolactate fermentation with Saccharomyces cerevisiae results in depletion of ATP and impaired metabolic activity!.’, FEMS Yeast Research, vol. 9, no. 3, pp. 349–57.

@adam3smith, it looks like the csl-bot examples don't localize. See e.g. #4221 (comment) (which is a Canadian French style), and the style in this PR. Is that a known issue?

(see also 7a6ab8d#issuecomment-514900188)

@rmzelle

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@MeijunHuang, after your report, we discovered that the sample references in the GitHub comments here ("Below are some sample citations generated based on your proposed changes:") didn't follow the style locale. This has been fixed now for all future pull requests. Thanks for alerting us of the problem.

@MeijunHuang

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.