Skip to content

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chicago-fullnote-bibliography-fr.csl #4294

Merged
merged 4 commits into from Sep 25, 2019
+691 −317

Conversation

@apinea
Copy link
Contributor

commented Sep 9, 2019

Style was edited to reflect changes made in most recent edition of Chicago (17th).
Changes recommended and verified by Pascal Martinolli, University of Montreal librarian.

Feuille.synthese.des.changements.a.faire.dans.le.style.CSL.pour.Zotero.docx
@apinea
Update chicago-fullnote-bibliography-fr.csl 
Style was edited to reflect changes made in most recent edition of Chicago (17th).
Changes recommended and verified by Pascal Martinolli, University of Montreal librarian.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5facf4c
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 9, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 9, 2019

😟 There are some issues with your submission.

1 test failed

chicago-fullnote-bibliography-fr: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "2:6: FATAL: XML declaration allowed only at the start of the document"]].empty?` to return true, got false

Please check the test report for details.
@apinea
Update chicago-fullnote-bibliography-fr.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
843cf2a
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 9, 2019

😟 There are some issues with your submission.

2 tests failed

chicago-fullnote-bibliography-fr: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "2:36: FATAL: Extra content at the end of the document"]].empty?` to return true, got false

chicago-fullnote-bibliography-fr: must be parsable as a CSL style

root node not CSL::Style: #<CSL::Node version="1.0" encoding="utf-8" children=[0]>

Please check the test report for details.
@apinea
Update chicago-fullnote-bibliography-fr.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e154876
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 9, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

chicago-fullnote-bibliography-fr.csl (modified style)
Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir.,Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York : Oxford University Press, 2007); « CSL search by example », Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.
Isabela Mares. « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Varieties of capitalism. The institutional foundations of comparative advantage, dir. Peter A. Hall et David Soskice (New York : Oxford University Press, 2001), 184‑213; Martin Fenner et al. « A data citation roadmap for scholarly data repositories », Scientific Data 6, nᵒ 1 (10 avril 2019) : 28. https://doi.org/10.1038/s41597-019-0031-8.
« CSL search by example ». Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. « A data citation roadmap for scholarly data repositories ». Scientific Data 6, nᵒ 1 (10 avril 2019) : 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York : Oxford University Press, 2007.
Mares, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » Dans Varieties of capitalism. The institutional foundations of comparative advantage, sous la direction de Peter A. Hall et David Soskice, 184‑213. New York : Oxford University Press, 2001.
-Bob Hancké, Martin Rhodes et Mark Thatcher, dir.<i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford and New York: Oxford University Press, 2007); « CSL search by example », <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares« Firms and the welfare state: When, why, and how does social policy matter to employers? », dans <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, dir. Peter A. Hall et David Soskice (New York: Oxford University Press, 2001), 184‑213; Martin Fenner et al.« A data citation roadmap for scholarly data repositories », <i>Scientific Data</i> 6, no 1 (10 avril 2019): 28, doi:10.1038/s41597-019-0031-8.<br/>
+Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir.,<i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford and New York&#160;: Oxford University Press, 2007); « CSL search by example », Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Isabela Mares. « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, dir. Peter A. Hall et David Soskice (New York&#160;: Oxford University Press, 2001), 184‑213; Martin Fenner <i>et al.</i> « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i> 6, nᵒ 1 (10 avril 2019)&#160;: 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
 <hr/>
-« CSL search by example ». <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand et al. « A data citation roadmap for scholarly data repositories ». <i>Scientific Data</i> 6, no 1 (10 avril 2019), 28. doi:10.1038/s41597-019-0031-8.<br/>
-Hancké, Bob, Martin Rhodes et Mark Thatcher, dir. <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
-Mares, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » Dans <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. Sous la direction de Peter A. Hall et David Soskice, 184‑213. New York: Oxford University Press, 2001.<br/>
+« CSL search by example ». Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, <i>et al.</i> « A data citation roadmap for scholarly data repositories ». <i>Scientific Data</i> 6, nᵒ 1 (10 avril 2019)&#160;: 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir. <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York&#160;: Oxford University Press, 2007.<br/>
+Mares, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » Dans <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, sous la direction de Peter A. Hall et David Soskice, 184‑213. New York&#160;: Oxford University Press, 2001.<br/>
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 9, 2019

My apologies -- this and your other style are at the top of my ToDo list and I'll get to a full review and hopefully merge this week; hoping for tomorrow (Tuesday).
@adam3smith
adam3smith reviewed Sep 16, 2019
View changes
chicago-fullnote-bibliography-fr.csl Outdated
</macro>
<macro name="originally-published">
<group delimiter=", ">
<group delimiter="&amp;#160;: ">

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith Sep 16, 2019

Member

I'm pretty sure you want &#160; here and in all other instances where you use it. This is true both for this and the author-date style
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 16, 2019

I have the same comment about et-al here as with the other style -- I'm pretty sure it shouldn't be in italics. Also, please fix the non-breaking spaces to &#160; throughout
@apinea
Update chicago-fullnote-bibliography-fr.csl
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b1d72a3
@apinea

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Sep 24, 2019

@adam3smith Thanks for your help. The recommended changes have been made to this newly updated version.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 24, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

chicago-fullnote-bibliography-fr.csl (modified style)
Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir.,Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy (Oxford and New York : Oxford University Press, 2007); « CSL search by example », Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.
Isabela Mares. « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Varieties of capitalism. The institutional foundations of comparative advantage, dir. Peter A. Hall et David Soskice (New York : Oxford University Press, 2001), 184‑213; Martin Fenner et al. « A data citation roadmap for scholarly data repositories », Scientific Data 6, nᵒ 1 (10 avril 2019) : 28. https://doi.org/10.1038/s41597-019-0031-8.
« CSL search by example ». Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. « A data citation roadmap for scholarly data repositories ». Scientific Data 6, nᵒ 1 (10 avril 2019) : 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir. Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy. Oxford and New York : Oxford University Press, 2007.
Mares, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » Dans Varieties of capitalism. The institutional foundations of comparative advantage, sous la direction de Peter A. Hall et David Soskice, 184‑213. New York : Oxford University Press, 2001.
-Bob Hancké, Martin Rhodes et Mark Thatcher, dir.<i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford and New York: Oxford University Press, 2007); « CSL search by example », <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares« Firms and the welfare state: When, why, and how does social policy matter to employers? », dans <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, dir. Peter A. Hall et David Soskice (New York: Oxford University Press, 2001), 184‑213; Martin Fenner et al.« A data citation roadmap for scholarly data repositories », <i>Scientific Data</i> 6, no 1 (10 avril 2019): 28, doi:10.1038/s41597-019-0031-8.<br/>
+Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir.,<i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i> (Oxford and New York : Oxford University Press, 2007); « CSL search by example », Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Isabela Mares. « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, dir. Peter A. Hall et David Soskice (New York : Oxford University Press, 2001), 184‑213; Martin Fenner et al. « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i> 6, nᵒ 1 (10 avril 2019) : 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
 <hr/>
-« CSL search by example ». <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand et al. « A data citation roadmap for scholarly data repositories ». <i>Scientific Data</i> 6, no 1 (10 avril 2019), 28. doi:10.1038/s41597-019-0031-8.<br/>
-Hancké, Bob, Martin Rhodes et Mark Thatcher, dir. <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
-Mares, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » Dans <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. Sous la direction de Peter A. Hall et David Soskice, 184‑213. New York: Oxford University Press, 2001.<br/>
+« CSL search by example ». Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. « A data citation roadmap for scholarly data repositories ». <i>Scientific Data</i> 6, nᵒ 1 (10 avril 2019) : 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir. <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York : Oxford University Press, 2007.<br/>
+Mares, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » Dans <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, sous la direction de Peter A. Hall et David Soskice, 184‑213. New York : Oxford University Press, 2001.<br/>

@adam3smith adam3smith merged commit 3219e97 into citation-style-language:master Sep 25, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 25, 2019

Terrific, thanks, and sorry for the initial delay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@apinea @csl-bot @adam3smith
You can’t perform that action at this time.