Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix perma_cc bug #24 #26
+24
−23
Conversation
This comment has been minimized.
This comment has been minimized.
Not sure why it failed AppVeyor - something about pdftools not running properly. |
This comment has been minimized.
This comment has been minimized.
Sorry this took a while, but this doesn't work for me and it almost looks like you reverted your fix in the second commit above? Output:
|
This comment has been minimized.
This comment has been minimized.
Also, as you suspect,
|
This comment has been minimized.
This comment has been minimized.
@greebie if you do work on this on Monday, could you take another look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
greebie commentedMar 10, 2019
The main issue was not as I suspected, but it was that the if--else was not being properly satisfied when the "NOT A URL" was being sent to the API.
NOTE: the latest commit may create another error for QDR's account, because the QDR account has multiple root rows as per #25 . If it does create a problem, I think it would be best to fix that issue in this PR too.