ORCID does not provide put-codes anymore in the website (zotero#1764)

We need now first an API call to receive the put-codes, with which we then can do calls for an individual work in CSL-JSON. * Avoid duplicates from works in the same activity group
adam3smith · Oct 12, 2018 · 4873ed66874230da6fc1ce1ad45272b7df865c50 · 4873ed6
1 parent d844751
commit 4873ed66874230da6fc1ce1ad45272b7df865c50
Unified Split

Showing with 30 additions and 26 deletions.

+30 −26 ORCID.js
diff --git a/ORCID.js b/ORCID.js
@@ -9,7 +9,7 @@
 	"inRepository": true,
 	"translatorType": 4,
 	"browserSupport": "gcsibv",
-  
-	"lastUpdated": "2018-07-11 15:36:09"
+  
+	"lastUpdated": "2018-10-12 18:52:49"
 }
 /*
@@ -36,28 +36,15 @@
 */
-  
-function getIds(doc,  url) {
-  
-	var rows = ZU.xpath(doc, '//ul[@id="body-work-list"]//li[@orcid-put-code]');
-  
-	var items = {};
-  
-	for (var i=0; i<rows.length; i++) {
-  
-		var id = rows[i].getAttribute("orcid-put-code");
-  
-		var title = ZU.xpathText(rows[i], './/h3/span[@ng-bind="work.title.value"]');
-  
-		items[id] = title;
-  
-	}
-  
-	//Z.debug(items);
-  
-	return items;
-  
-}
-  
-
-  
-
 function detectWeb(doc, url) {
 	//check that orcid can be found
 	var orcid = doc.getElementById("orcid-id");
 	if (!orcid) {
 		Z.debug("Error: No ORCID found in this page");
 		return false;
 	}
-  
-	//check that work ids can be found
-  
-	if (getIds(doc, url) !== null) {
+  
+	//check that some works are listed on that page
+  
+	if (ZU.xpath(doc, '//ul[@id="body-work-list"]/li').length) {
 		return "multiple";
 	}
 }
@@ -66,9 +53,6 @@ function detectWeb(doc, url) {
 function lookupWork(workid, orcid) {
 	var callApi = 'https://pub.orcid.org/v2.0/' + orcid + '/work/' + workid;
 	ZU.doGet(callApi, function(text){
-  
-		//Z.debug(callApi);
-  
-		//Z.debug(text);
-  
-
 		var translator = Zotero.loadTranslator("import");
 		translator.setTranslator("bc03b4fe-436d-4a1f-ba59-de4d2d7a63f7");//CSL JSON
 		translator.setString(text);
@@ -81,15 +65,35 @@ function lookupWork(workid, orcid) {
 function doWeb(doc, url) {
 	var orcid = doc.getElementById("orcid-id");
 	orcid = orcid.textContent.replace('https://orcid.org/', '');
-  
-	Zotero.selectItems(getIds(doc, url), function (items) {
-  
-		if (!items) {
-  
-			return true;
-  
-		}
-  
-		for (var i in items) {
-  
-			lookupWork(i, orcid);
+  
+	var callApi = 'https://pub.orcid.org/v2.0/' + orcid + '/works';
+  
+	ZU.doGet(callApi, function(text) {
+  
+		// Z.debug(text);
+  
+		var parser = new DOMParser();
+  
+		var doc = parser.parseFromString(text, "application/xml");
+  
+		var namespaces = {
+  
+			"work": "http://www.orcid.org/ns/work",
+  
+			"activities": "http://www.orcid.org/ns/activities"
+  
+		};
+  
+		var items = ZU.xpath(doc, '//activities:group', namespaces);
+  
+		var putCodes = {};
+  
+		for (let item of items) {
+  
+			let work = ZU.xpath(item, './work:work-summary', namespaces)[0];
+  
+			let code = work.getAttribute('put-code');
+  
+			let title = ZU.xpathText(work, './/work:title', namespaces);
+  
+			putCodes[code] = title.trim();
 		}
+  
+		Zotero.selectItems(putCodes, function (items) {
+  
+			if (!items) {
+  
+				return true;
+  
+			}
+  
+			for (var i in items) {
+  
+				lookupWork(i, orcid);
+  
+			}
+  
+		});
 	});
-  
-}/** BEGIN TEST CASES **/
+  
+}
+  
+
+  
+/** BEGIN TEST CASES **/
 var testCases = [
 	{
 		"type": "web",