New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMS MathSciNet -- Target needs update #1451

Closed
adam3smith opened this Issue Oct 20, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@adam3smith
Collaborator

adam3smith commented Oct 20, 2017

According to report https://forums.zotero.org/discussion/68245/ams-mathscinet-broken#latest
all that's needed is switching www. --> mathscinet. in target, though haven't checked

@gjankowiak

This comment has been minimized.

Show comment
Hide comment
@gjankowiak

gjankowiak Oct 20, 2017

Contributor

I (initial reporter) just want to mention that I'm not familiar with how Zotero works, I tried unpacking/modifying/repacking zotero.jar, with no effects. I basically replaced all occurences of www. with mathscinet., since I don't know how the zotero/firefox/zotero-connector ecosystem works, this might make no sense.

After that I roll-backed my changes and modified .mozilla/firefox/XXX.default/browser-extension-data/zotero@chnm.gmu.edu/storage.js which is significantly more simple and has only one occurence of the mathscinet url, and this seemed to do the trick.

Contributor

gjankowiak commented Oct 20, 2017

I (initial reporter) just want to mention that I'm not familiar with how Zotero works, I tried unpacking/modifying/repacking zotero.jar, with no effects. I basically replaced all occurences of www. with mathscinet., since I don't know how the zotero/firefox/zotero-connector ecosystem works, this might make no sense.

After that I roll-backed my changes and modified .mozilla/firefox/XXX.default/browser-extension-data/zotero@chnm.gmu.edu/storage.js which is significantly more simple and has only one occurence of the mathscinet url, and this seemed to do the trick.

@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Oct 20, 2017

Collaborator

The translators are simple, individual .js files in the translators directory in the Zotero data folder: https://www.zotero.org/support/zotero_data you can change them on the fly and won't need any repacking. The relevant line is the taget at the top.
(In the case of changing targets, you'll need to restart Zotero and browser after making that change)
I wouldn't touch any of the other components of Zotero in a system you're using for work.

Collaborator

adam3smith commented Oct 20, 2017

The translators are simple, individual .js files in the translators directory in the Zotero data folder: https://www.zotero.org/support/zotero_data you can change them on the fly and won't need any repacking. The relevant line is the taget at the top.
(In the case of changing targets, you'll need to restart Zotero and browser after making that change)
I wouldn't touch any of the other components of Zotero in a system you're using for work.

gjankowiak added a commit to gjankowiak/translators that referenced this issue Oct 20, 2017

Update AMS MathSciNet.js target (#1451)
changed initial subdomain from www. to mathscinet.. Also updated test cases.
Fixes #1451.
@gjankowiak

This comment has been minimized.

Show comment
Hide comment
@gjankowiak

gjankowiak Oct 20, 2017

Contributor

Thank you for the explaination! I've just filed a pull requests for thoses changes. I updated also the subdomain in the code, since I guess the redirects won't be active forever.

Contributor

gjankowiak commented Oct 20, 2017

Thank you for the explaination! I've just filed a pull requests for thoses changes. I updated also the subdomain in the code, since I guess the redirects won't be active forever.

@adam3smith adam3smith closed this in #1452 Oct 21, 2017

adam3smith added a commit that referenced this issue Oct 21, 2017

Update AMS MathSciNet.js target (#1451) (#1452)
changed initial subdomain from www. to mathscinet.. Also updated test cases.
Fixes #1451.

* [AMS MathSciNet.js] switch to HTTPS + test cleanup

psisquared2 added a commit to psisquared2/translators that referenced this issue Feb 8, 2018

Update AMS MathSciNet.js target (#1451) (#1452)
changed initial subdomain from www. to mathscinet.. Also updated test cases.
Fixes #1451.

* [AMS MathSciNet.js] switch to HTTPS + test cleanup

zuphilip added a commit to zuphilip/translators that referenced this issue Mar 28, 2018

Update AMS MathSciNet.js target (#1451) (#1452)
changed initial subdomain from www. to mathscinet.. Also updated test cases.
Fixes #1451.

* [AMS MathSciNet.js] switch to HTTPS + test cleanup

zuphilip added a commit to zuphilip/translators that referenced this issue Mar 28, 2018

Update AMS MathSciNet.js target (#1451) (#1452)
changed initial subdomain from www. to mathscinet.. Also updated test cases.
Fixes #1451.

* [AMS MathSciNet.js] switch to HTTPS + test cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment