Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate search and import translators #1316
Conversation
zuphilip
added some commits
Jun 3, 2017
DataCite.js
| "date": "1734", | ||
| "itemID": "https://doi.org/10.12763/ona1045", | ||
| "abstractNote": "[object Object],[object Object],[object Object]", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 3, 2017
Collaborator
The abstract looks strange because the CSL JSON from DataCite looks like this:
"abstract": [
{
"type": "Other",
"text": "Le code est accompagné de commentaires de F. A. Vogel, qui signe l'épitre dédicatoire"
},
{
"type": "Other",
"text": "Reliure 18è siècle"
},
{
"type": "Other",
"text": "Ex-libris manuscrit \"Ex libris Dufour\""
}
],
zuphilip
Jun 3, 2017
Collaborator
The abstract looks strange because the CSL JSON from DataCite looks like this:
"abstract": [
{
"type": "Other",
"text": "Le code est accompagné de commentaires de F. A. Vogel, qui signe l'épitre dédicatoire"
},
{
"type": "Other",
"text": "Reliure 18è siècle"
},
{
"type": "Other",
"text": "Ex-libris manuscrit \"Ex libris Dufour\""
}
],
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Jun 3, 2017
Collaborator
@mfenner are we going to see this a lot? What exactly are the specs for this? We might want to check & concat.
adam3smith
Jun 3, 2017
Collaborator
@mfenner are we going to see this a lot? What exactly are the specs for this? We might want to check & concat.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mfenner
Jun 3, 2017
Contributor
This is a bug. I opened an issue at datacite/bolognese#11, you should expect a string.
mfenner
Jun 3, 2017
Contributor
This is a bug. I opened an issue at datacite/bolognese#11, you should expect a string.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mfenner
Jun 3, 2017
Contributor
The bug has been fixed, you should now get
"abstract": "Le code est accompagné de commentaires de F. A. Vogel, qui signe l'épitre dédicatoire",
mfenner
Jun 3, 2017
Contributor
The bug has been fixed, you should now get
"abstract": "Le code est accompagné de commentaires de F. A. Vogel, qui signe l'épitre dédicatoire",
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 4, 2017
Collaborator
Yes, I can confirm that the output is now a string. Thank you very much for this very fast bug fixing!
zuphilip
Jun 4, 2017
Collaborator
Yes, I can confirm that the output is now a string. Thank you very much for this very fast bug fixing!
| @@ -105,9 +105,11 @@ var testCases = [ | ||
| "seeAlso": [], | ||
| "attachments": [], | ||
| "title": "Code criminel de l'empereur Charles V vulgairement appellé la Caroline contenant les loix qui sont suivies dans les jurisdictions criminelles de l'Empire et à l'usage des conseils de guerre des troupes suisses.", | ||
| "url": "http://dx.doi.org/10.12763/ONA1045", | ||
| "DOI": "10.12763/ONA1045", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Jun 3, 2017
Collaborator
we should add DOIs to extra for everything but journals&conference papers the way we do for CrossRef
adam3smith
Jun 3, 2017
Collaborator
we should add DOIs to extra for everything but journals&conference papers the way we do for CrossRef
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 3, 2017
Collaborator
The deletion of the DOI for a report is here triggered by ZU.itemFromCSLJSON (I guess this line).
However, we can also add the DOI in extra again in the DataCite translator. I will do this later...
zuphilip
Jun 3, 2017
Collaborator
The deletion of the DOI for a report is here triggered by ZU.itemFromCSLJSON (I guess this line).
However, we can also add the DOI in extra again in the DataCite translator. I will do this later...
Library of Congress ISBN.js
| @@ -8,7 +8,7 @@ | ||
| "priority": 98, | ||
| "inRepository": true, | ||
| "translatorType": 8, | ||
| "browserSupport": "gcsb", | ||
| "browserSupport": "gcsibv", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Jun 3, 2017
Collaborator
Why don't we need to bump the timestamp here? E.g. when using the bookmarklet to save to Standalone this would matter, no?
adam3smith
Jun 3, 2017
Collaborator
Why don't we need to bump the timestamp here? E.g. when using the bookmarklet to save to Standalone this would matter, no?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 3, 2017
Collaborator
True. I will bump the timestamps for the translators with extended browserSupport.
zuphilip
Jun 3, 2017
Collaborator
True. I will bump the timestamps for the translators with extended browserSupport.
mfenner
referenced this pull request
Jun 3, 2017
Closed
Abstract should be a string in Citeproc writer #11
zuphilip
added some commits
Jun 3, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Please have a look at the new version. |
adam3smith
merged commit f5be7ba
into
zotero:master
Jun 4, 2017
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Great, thanks! |
zuphilip
deleted the
zuphilip:update-search-translators
branch
Jun 4, 2017
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip commentedJun 3, 2017
No description provided.