Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRewrite IMDb.js #1331
Conversation
adam3smith
reviewed
Jun 22, 2017
2 questions -- very much possible that neither requires any changes to your code, just making sure.
| } | ||
| var summary = ZU.xpath(doc, '//div[contains(@class, "plot_summary_wrapper")]'); | ||
| var creatorsMapping = { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 22, 2017
Collaborator
I haven't seen any other role in the short list in the overview e.g. http://www.imdb.com/title/tt0089276/ but there are much more persons in the long list e.g. http://www.imdb.com/title/tt0089276/fullcredits?ref_=tt_ov_st_sm . Do you think it is worth to grab more persons from there? Zotero has AFAIK only another role producer for films. But I wasn't even sure about the many actors...
zuphilip
Jun 22, 2017
Collaborator
I haven't seen any other role in the short list in the overview e.g. http://www.imdb.com/title/tt0089276/ but there are much more persons in the long list e.g. http://www.imdb.com/title/tt0089276/fullcredits?ref_=tt_ov_st_sm . Do you think it is worth to grab more persons from there? Zotero has AFAIK only another role producer for films. But I wasn't even sure about the many actors...
| "extra": "IMDB ID: tt0089276\nIMDB Rating: 7.8 (5,300 votes)", | ||
| "date": "1985-11-08", | ||
| "abstractNote": "Directed by Luis Puenzo. With Norma Aleandro, Héctor Alterio, Chunchuna Villafañe, Hugo Arana. After the end of the Dirty War, a high school teacher sets out to find out who the mother of her adopted daughter is.", | ||
| "extra": "original-title: La historia oficial\nIMDb ID: tt0089276", | ||
| "genre": "Drama, History, War", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Jun 22, 2017
Collaborator
I wonder if this makes sense. This is, clearly, the genre, but it this a good field?
adam3smith
Jun 22, 2017
Collaborator
I wonder if this makes sense. This is, clearly, the genre, but it this a good field?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jun 22, 2017
Collaborator
From https://aurimasv.github.io/z2csl/typeMap.xml
genre = [standard] class, type or genre of the item (e.g. “adventure” for an adventure movie, “PhD dissertation” for a PhD thesis)
But I am open for any other suggestion.
zuphilip
Jun 22, 2017
Collaborator
From https://aurimasv.github.io/z2csl/typeMap.xml
genre = [standard] class, type or genre of the item (e.g. “adventure” for an adventure movie, “PhD dissertation” for a PhD thesis)
But I am open for any other suggestion.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
merged commit 0133798
into
zotero:master
Jun 22, 2017
1 check passed
zuphilip
deleted the
zuphilip:imdb
branch
Jun 22, 2017
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip commentedJun 16, 2017
See https://forums.zotero.org/discussion/comment/277844/#Comment_277844