Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRewrite TV by the Numbers #1360
Conversation
sonali0901
added some commits
Jul 7, 2017
TV by the Numbers.js
| return reg.exec(xpmatch)[1]; | ||
| function doWeb(doc, url) { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jul 8, 2017
Collaborator
You already have the function doWeb above, i.e. this is duplicate content and should be deleted.
zuphilip
Jul 8, 2017
Collaborator
You already have the function doWeb above, i.e. this is duplicate content and should be deleted.
TV by the Numbers.js
| else if (author_text.indexOf(";") != -1) | ||
| authors = author_text.split(";"); | ||
| translator.setHandler('itemDone', function(obj, item) { | ||
| item.date = ZU.strToISO(item.date); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jul 8, 2017
Collaborator
Maybe check here before that item.date exists, i.e.
if (item.date) {
item.date = ZU.strToISO(item.date);
}
zuphilip
Jul 8, 2017
Collaborator
Maybe check here before that item.date exists, i.e.
if (item.date) {
item.date = ZU.strToISO(item.date);
}TV by the Numbers.js
| if (authors[i].textContent == 'TV By The Numbers') | ||
| item.creators.push({ | ||
| lastName: authors[i].textContent, | ||
| creatorType: "author", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
owcz
Jul 10, 2017
Contributor
"Author" sounds most appropriate, based on how it's used in the byline:
http://tvbythenumbers.zap2it.com/sdsdskdh279882992z1/tv-ratings-friday-grimm-constantine-fall-shark-tank-the-amazing-race-last-man-standing-up-cristela-hawaii-five-0-steady/
owcz
Jul 10, 2017
Contributor
"Author" sounds most appropriate, based on how it's used in the byline:
http://tvbythenumbers.zap2it.com/sdsdskdh279882992z1/tv-ratings-friday-grimm-constantine-fall-shark-tank-the-amazing-race-last-man-standing-up-cristela-hawaii-five-0-steady/
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jul 16, 2017
Collaborator
Correct, but I don't think we want to have TV By The Numbers as author in any citation, which is actually the name of the blogTitle/websiteTitle. Maybe, we should ignore author information completely, when it is only mentioned TV By The Numbers. CC @adam3smith
zuphilip
Jul 16, 2017
Collaborator
Correct, but I don't think we want to have TV By The Numbers as author in any citation, which is actually the name of the blogTitle/websiteTitle. Maybe, we should ignore author information completely, when it is only mentioned TV By The Numbers. CC @adam3smith
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
TV by the Numbers.js
| return "multiple"; | ||
| else if (doc.body.className.indexOf("single-post") > -1) | ||
| return "webpage"; |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Jul 8, 2017
Collaborator
Should we change this to blogPost, which might be less generic? Moreover, the website uses WordPress...
zuphilip
Jul 8, 2017
Collaborator
Should we change this to blogPost, which might be less generic? Moreover, the website uses WordPress...
TV by the Numbers.js
| "abstractNote": "Final broadcast primetime live + same-day ratings for Monday, July 3, 2017 The top show on a rerun-filled Monday night saw its adults 18-49 rating grow from the preliminary numbers to the finals. &…", | ||
| "shortTitle": "‘American Ninja Warrior’ adjusts up", | ||
| "url": "http://tvbythenumbers.zap2it.com/daily-ratings/monday-final-ratings-july-3-2017/", | ||
| "websiteTitle": "TV By The Numbers by zap2it.com", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
owcz
Jul 10, 2017
Contributor
I'd set the website title in the scraper so that it reads "TV By The Numbers" (not the name EM found)
owcz
Jul 10, 2017
Contributor
I'd set the website title in the scraper so that it reads "TV By The Numbers" (not the name EM found)
TV by the Numbers.js
| if (authors[i].textContent == 'TV By The Numbers') | ||
| item.creators.push({ | ||
| lastName: authors[i].textContent, | ||
| creatorType: "author", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
owcz
Jul 10, 2017
Contributor
"Author" sounds most appropriate, based on how it's used in the byline:
http://tvbythenumbers.zap2it.com/sdsdskdh279882992z1/tv-ratings-friday-grimm-constantine-fall-shark-tank-the-amazing-race-last-man-standing-up-cristela-hawaii-five-0-steady/
owcz
Jul 10, 2017
Contributor
"Author" sounds most appropriate, based on how it's used in the byline:
http://tvbythenumbers.zap2it.com/sdsdskdh279882992z1/tv-ratings-friday-grimm-constantine-fall-shark-tank-the-amazing-race-last-man-standing-up-cristela-hawaii-five-0-steady/
TV by the Numbers.js
| "title": "Snapshot" | ||
| }], | ||
| "tags": [ | ||
| "'", |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
owcz
Jul 10, 2017
Contributor
If the "Category" is blank (or a single quote) in all articles, it should be removed. Also title case works better than lower case for the tags. They're in title case within the article, if you want to pull those phrases instead of reworking what EM found
owcz
Jul 10, 2017
Contributor
If the "Category" is blank (or a single quote) in all articles, it should be removed. Also title case works better than lower case for the tags. They're in title case within the article, if you want to pull those phrases instead of reworking what EM found
sonali0901
and others
added some commits
Jul 11, 2017
adam3smith
merged commit b1a7088
into
zotero:master
Oct 1, 2017
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks! |
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
sonali0901 commentedJul 7, 2017
Fixes #149