/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upade DeGruyter #1393

Merged
merged 3 commits into from Aug 31, 2017
+133 −95

Conversation

Reviewers

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zuphilip @adam3smith
@zuphilip
Collaborator

zuphilip commented Aug 26, 2017

This makes sure that EM translator will find these meta
tags. However, the translator seems only to fix the
journal articles from DeGruyter. Only the test cases
for journal articles are updated.

Relates to #1390.

zuphilip added some commits Aug 26, 2017

@zuphilip
DeGruyter: Copy HighWire tags from body to head 
This makes sure that EM translator will find these meta
tags. However, the translator seems only to fix the
journal articles from DeGruyter. Only the test cases
for journal articles are updated.

Relates to #1390.
07ec8ac
@zuphilip
DeGruyter: Fix RIS extraction and multiples 
This solves #1390.
3816292

@zuphilip zuphilip changed the title from DeGruyter: Copy HighWire tags from body to head to Upade DeGruyter Aug 27, 2017

@adam3smith

adam3smith reviewed Aug 27, 2017
View changes

One question and potential nit; otherwise looks good, thanks!

Show outdated Hide outdated DeGruyter.js
@@ -94,113 +94,133 @@ function doWeb(doc, url) {
}
function scrapeRIS(doc, url) {
urlRIS = ZU.xpathText(doc,'//li[@class="cite"]/a/@href');
var urlCite = ZU.xpathText(doc,'(//li[@class="cite"])[1]/a/@href');
var productId = urlCite.replace('?nojs=true', '').replace('/dg/cite/', '');

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Aug 27, 2017

Collaborator

shouldn't we just do a blanket replace on [?#].+ to be safe(r)?
Copy URL
@adam3smith

adam3smith Aug 27, 2017

Collaborator

shouldn't we just do a blanket replace on [?#].+ to be safe(r)?
@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Aug 28, 2017

Collaborator

Please have a look at the new version.
Collaborator

zuphilip commented Aug 28, 2017

Please have a look at the new version.

@adam3smith adam3smith merged commit 523aca8 into zotero:master Aug 31, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Aug 31, 2017

Collaborator

Great, thanks!
Collaborator

adam3smith commented Aug 31, 2017

Great, thanks!

@zuphilip zuphilip deleted the zuphilip:degruyter-meta branch Aug 31, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Upade DeGruyter (#1393) 
* DeGruyter: Copy HighWire tags from body to head

This makes sure that EM translator will find these meta
tags. 
* DeGruyter: Fix RIS extraction and multiples

This solves #1390.
a42cc46

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

@zuphilip
Upade DeGruyter (#1393) 
* DeGruyter: Copy HighWire tags from body to head

This makes sure that EM translator will find these meta
tags. 
* DeGruyter: Fix RIS extraction and multiples

This solves #1390.
8f378d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment