Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Jahrbuch.js] Add compatibility with Chrome and Safari #1464
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Nov 7, 2017
Collaborator
going to take this bc it doesn't hurt, but since the goal is to just drop the check in the connectors, I wouldn't bother updating this in the other translators unless you're making other changes.
|
going to take this bc it doesn't hurt, but since the goal is to just drop the check in the connectors, I wouldn't bother updating this in the other translators unless you're making other changes. |
adam3smith
merged commit 4aa8049
into
zotero:master
Nov 7, 2017
1 check passed
zuphilip
deleted the
zuphilip:chrome-safari
branch
Nov 7, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dstillman
Nov 8, 2017
Member
I fixed the encoding problem in zotero/zotero@bb1cbdf, which is now available in the 5.0 Beta. There's still a mismatch on the abstract, but it looks like that's due to an HTML entity change ($< 180^\\circ$ -> $< 180^\\circ$).
|
I fixed the encoding problem in zotero/zotero@bb1cbdf, which is now available in the 5.0 Beta. There's still a mismatch on the abstract, but it looks like that's due to an HTML entity change ( |
added a commit
to psisquared2/translators
that referenced
this pull request
Feb 8, 2018
zuphilip commentedNov 4, 2017
•
edited
Edited 2 times
-
zuphilip
edited Nov 4, 2017 (most recent)
-
zuphilip
edited Nov 4, 2017
The translator looks fine and I tested it successfully with Chrome as well.
However, the test within Scaffold did not match because of encoding problems. The encoding should be handled in the
doGetcall. @dstillman Can Scaffold handle suchdoGetcalls with a special encoding as well?Relates to zotero/zotero-connectors#197