Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMisc fixes for Cairn translator #1473
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Nov 11, 2017
Collaborator
Related discussion on Twitter: https://twitter.com/amarois/status/928653241365262338
|
Related discussion on Twitter: https://twitter.com/amarois/status/928653241365262338 |
zuphilip
self-requested a review
Nov 11, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Nov 11, 2017
Collaborator
Thank you for this pull request, @symac.
I just did some cleanup and small improvements. Please have a look.
Do you have an example for a book chapter?
(Maybe we should also consider to take the RIS data that Cairn provides under Citer cet article at some point...)
|
Thank you for this pull request, @symac. I just did some cleanup and small improvements. Please have a look. Do you have an example for a book chapter? (Maybe we should also consider to take the RIS data that Cairn provides under |
zuphilip
removed their request for review
Nov 11, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
symac
Nov 13, 2017
Contributor
Thanks @zuphilip for the cleanup. A book chapter example is http://www.cairn.info/jeu-d-echecs-comme-representation--9782728835904-page-111.htm
I think this .ris is quite new, I have never noticed it. That would maybe be a better way to get data yes, but I have not much time at the moment to check if it is complete so I believe that might wait :)
|
Thanks @zuphilip for the cleanup. A book chapter example is http://www.cairn.info/jeu-d-echecs-comme-representation--9782728835904-page-111.htm I think this .ris is quite new, I have never noticed it. That would maybe be a better way to get data yes, but I have not much time at the moment to check if it is complete so I believe that might wait :) |
zuphilip
merged commit 432125c
into
zotero:master
Nov 13, 2017
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Nov 13, 2017
Collaborator
I fixed the bookSection case according to your example.
Thank you very much @symac !
|
I fixed the bookSection case according to your example. Thank you very much @symac ! |
added a commit
to psisquared2/translators
that referenced
this pull request
Feb 8, 2018
symac commentedNov 10, 2017
Have been fixed :