Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed Bookmarks.js HTML character references in title. #1496
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Dec 15, 2017
Collaborator
@ckush Okay, that looks fine. But you need to update the lastUpdated-timestamp at the top of this file as well. Otherwise this will not get distributed.
|
@ckush Okay, that looks fine. But you need to update the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ckush
Dec 15, 2017
Contributor
@zuphilip I have updated the timestamp.
Also, I realised I created I new branch patch-1. I don't remember how this happened, as I'm very new to all this. Ideally, was I supposed to keep it to master?
|
@zuphilip I have updated the timestamp. Also, I realised I created I new branch |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
Dec 15, 2017
Collaborator
patch-1 is automatically created when you create forks from github online and it's the recommended way to work so that your local master branch is always "clean"
|
patch-1 is automatically created when you create forks from github online and it's the recommended way to work so that your local master branch is always "clean" |
zuphilip
merged commit ce38a08
into
zotero:master
Dec 15, 2017
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
|
zuphilip
referenced this pull request
Dec 15, 2017
Closed
Bookmarks translator fails to unescape HTML character references in title names. #1485
added a commit
to adam3smith/translators
that referenced
this pull request
Dec 21, 2017
added a commit
to adam3smith/translators
that referenced
this pull request
Dec 21, 2017
added a commit
to psisquared2/translators
that referenced
this pull request
Feb 8, 2018
ckush commentedDec 12, 2017
•
edited
Edited 1 time
-
ckush
edited Dec 12, 2017 (most recent)
Importing bookmarks in Zotero left symbols like
&and'in title. This fix changes them to the original character.This issue was discussed here: #1485