Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[PICA] Fix multiples in SUDOC #1530
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@symac @adomasven Please test if this works for you. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
symac
Jan 26, 2018
Contributor
Thanks @zuphilip this is almost perfect except that Library Catalog (PICA).js#587 needs to be changed from :
newUrl.replace(/sudoc\.abes\.fr\/\/?DB=/, 'sudoc.abes.fr/xslt/DB=');
to
newUrl = newUrl.replace(/sudoc\.abes\.fr\/\/?DB=/, 'sudoc.abes.fr/xslt/DB=');
otherwise the replacement is not affected anywhere, I spent some minutes trying to debug before noticing this obvious thing :) Thanks for the quick fix!
|
Thanks @zuphilip this is almost perfect except that Library Catalog (PICA).js#587 needs to be changed from : otherwise the replacement is not affected anywhere, I spent some minutes trying to debug before noticing this obvious thing :) Thanks for the quick fix! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks for the hint. Should be fixed now. |
zuphilip
merged commit d936099
into
zotero:master
Jan 26, 2018
1 check passed
zuphilip
deleted the
zuphilip:sudoc-1529
branch
Jan 26, 2018
added a commit
to GuyAglionby/translators
that referenced
this pull request
Jan 28, 2018
added a commit
to psisquared2/translators
that referenced
this pull request
Feb 8, 2018
zuphilip commentedJan 26, 2018
see #1529