Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix incorrect type returned for ResearchGate #1534
+2
−1
Conversation
zuphilip
merged commit ee7cfa6
into
zotero:master
Jan 28, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
zuphilip
Jan 28, 2018
Collaborator
Thank you @GuyAglionby ! Everything looks fine and the test case now detect again the correct case.
|
Thank you @GuyAglionby ! Everything looks fine and the test case now detect again the correct case. |
added a commit
to psisquared2/translators
that referenced
this pull request
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
GuyAglionby commentedJan 28, 2018
The inclusion of
(PDF Available)in the text that the translator was using to determine type was causing it to fail, so I have fixed this. No failing test added as the existing one for URLhttps://www.researchgate.net/publication/315673297_Linguistic_Landscape_Bibliography_on_Zoterowas already failing.Any comments welcome. I think using the RIS data is still a valid approach -- the BibTeX export they provide isn't any more reliable.
Thanks :)