Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate newspapers.com.js to work with current site html #1596
Conversation
pbinkley
and others
added some commits
Mar 18, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Mar 24, 2018
Collaborator
Thank you! I updated some of the XPath/CSS path further in order to have something more stable (hopefully). Moreover, I added another test case and pushed everything to your branch. @pbinkley Can you check that this looks fine for you?
|
Thank you! I updated some of the XPath/CSS path further in order to have something more stable (hopefully). Moreover, I added another test case and pushed everything to your branch. @pbinkley Can you check that this looks fine for you? |
zuphilip
requested a review
from
adam3smith
Mar 24, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pbinkley
Apr 15, 2018
Contributor
Sorry for neglecting this - thanks for the cleanup, and please merge.
|
Sorry for neglecting this - thanks for the cleanup, and please merge. |
zuphilip
removed the request for review
from
adam3smith
Apr 15, 2018
zuphilip
merged commit 134828f
into
zotero:master
Apr 15, 2018
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zuphilip
Apr 15, 2018
Collaborator
@pbinkley Thank you! It is merge now and squashed before. Please make sure that you will sync your master branch again before you continue to work on anything else.
|
@pbinkley Thank you! It is merge now and squashed before. Please make sure that you will sync your master branch again before you continue to work on anything else. |
pbinkley commentedMar 18, 2018
newspapers.com has modified their html structures; this PR brings the translator up to date.