New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOI search for Airiti #1627

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Apr 17, 2018

Collaborator

@grolimur Testing is welcome.

Collaborator

zuphilip commented Apr 17, 2018

@grolimur Testing is welcome.

@grolimur

This comment has been minimized.

Show comment
Hide comment
@grolimur

grolimur Apr 18, 2018

Passed most of the tests I made (with the following DOIs provided by Airiti):

10.6224/JN.60.3.88
10.6180/jase.1998.1.1.02
10.6531/1105aaa (failed)
10.6220/joq.2012.19(1).01
10.5870/1111 (failed)
10.5870/2222

grolimur commented Apr 18, 2018

Passed most of the tests I made (with the following DOIs provided by Airiti):

10.6224/JN.60.3.88
10.6180/jase.1998.1.1.02
10.6531/1105aaa (failed)
10.6220/joq.2012.19(1).01
10.5870/1111 (failed)
10.5870/2222

@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip Apr 18, 2018

Collaborator

The first failed test case is not registered as an DOI, cf. http://doi.org/10.6531/1105aaa

The other error is because the DOI redirects to another website http://ir.lib.cyut.edu.tw:8080/handle/310901800/14305 which will lead to an error in the scrape.

Other DOI agencies have APIs which we can use within Zotero. I don't know whether there is any other way to receive metadata info about DOIs from Airiti...

Collaborator

zuphilip commented Apr 18, 2018

The first failed test case is not registered as an DOI, cf. http://doi.org/10.6531/1105aaa

The other error is because the DOI redirects to another website http://ir.lib.cyut.edu.tw:8080/handle/310901800/14305 which will lead to an error in the scrape.

Other DOI agencies have APIs which we can use within Zotero. I don't know whether there is any other way to receive metadata info about DOIs from Airiti...

@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Apr 18, 2018

Collaborator

I'll go ahead and merge this. Clearly an improvement over the status quo and I don't see any obvious improvement

Collaborator

adam3smith commented Apr 18, 2018

I'll go ahead and merge this. Clearly an improvement over the status quo and I don't see any obvious improvement

@grolimur

This comment has been minimized.

Show comment
Hide comment
@grolimur

grolimur commented Apr 20, 2018

👍

@adam3smith adam3smith merged commit 3ddfa9b into zotero:master Apr 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zuphilip zuphilip deleted the zuphilip:airiti-search-doi branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment