/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScienceDirect: fixes a buggy pdf query selector #1661

Merged
merged 1 commit into from May 21, 2018
+2 −2

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adomasven @zuphilip
@adomasven
Member

adomasven commented May 21, 2018

Report here https://forums.zotero.org/discussion/comment/307937/#Comment_307937

Safari seems to be served different content than other browsers and the conditional branch on that different content had a buggy query selector.

@zuphilip zuphilip merged commit 85ecb63 into zotero:master May 21, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zuphilip

This comment has been minimized.

Show comment
Hide comment
@zuphilip

zuphilip May 21, 2018

Collaborator

Thank you very much @adomasven!

BTW do you also see "error parsing XML" in Scaffold when running the automatic tests? Cf. zotero/scaffold#74
Collaborator

zuphilip commented May 21, 2018

Thank you very much @adomasven!

BTW do you also see "error parsing XML" in Scaffold when running the automatic tests? Cf. zotero/scaffold#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment