Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSciencedirect book main pages #1720
Conversation
mbwhitfield
added some commits
Aug 21, 2018
mbwhitfield
changed the title from
Book main pages
to
Sciencedirect book main pages
Aug 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adam3smith
commented
Aug 21, 2018
•
edited
Edited 1 time
-
adam3smith
edited Aug 21, 2018 (most recent)
-
adam3smith
created Aug 21, 2018
edited
-
Aug 21, 2018 (most recent) -
Aug 21, 2018
|
thanks! could you post a url to which this applies? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mbwhitfield
Aug 21, 2018
Contributor
Sure, this is what I was aiming at: https://www.sciencedirect.com/book/9781893997981/industrial-oil-crops
|
Sure, this is what I was aiming at: https://www.sciencedirect.com/book/9781893997981/industrial-oil-crops |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mbwhitfield
Aug 22, 2018
Contributor
By coincidence, I found a problem with the code to identify whether there is an RIS export button on the page (probably b/c of changes in the sciencedirect website). I made the edit to my fork, not realizing it would automatically add to the pull request (github newbie). Hope that's not a problem.
Example URL: https://www.sciencedirect.com/science/article/pii/S0921042300800180
I simply removed the class from the button element on line 477. Since it's underneath div[@class="ExportCitation"], I don't think that will break anything.
|
By coincidence, I found a problem with the code to identify whether there is an RIS export button on the page (probably b/c of changes in the sciencedirect website). I made the edit to my fork, not realizing it would automatically add to the pull request (github newbie). Hope that's not a problem. |
adam3smith
merged commit 2b85a07
into
zotero:master
Aug 24, 2018
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks! |
mbwhitfield commentedAug 21, 2018
Changed target to make "science/" in URL optional, to hopefully accomodate old and new sciencedirect non-article pages.
Also added code to ZU.xpath to identify chapters on book main pages. (This also fixed detectweb on book main pages, which requires getArticleList to not be empty in order to return "multiple".)