Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterpriseslint names with spaces #1953
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looks good to me, but my shell scripting is lousy. @dstillman could you please do a quick sanity check and merge if this looks OK? |
dstillman
merged commit bd425d7
into
zotero:master
Jun 10, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
retorquere
deleted the
retorquere:teslint-spaces
branch
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
retorquere commentedJun 9, 2019
The previous invocation of teslint would run
rather than