Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade blacklight to version 7.2.0 #87
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
@depfu rebase |
depfu
bot
force-pushed the
depfu/update/blacklight-7.2.0
branch
from
Oct 15, 2019
72d97d3
to
fe7304c
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Oct 15, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedOct 11, 2019
•
edited
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
7.2.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 59 commits:
Bump to v7.2.0
Merge pull request #2148 from projectblacklight/asi
Merge pull request #2175 from projectblacklight/stanza
Add a requirement for sass-rails 5
Merge pull request #2118 from projectblacklight/merging-criteria-but-MORE
Merge pull request #2169 from projectblacklight/facet-field-names
Merge pull request #2167 from projectblacklight/facet_group
Merge pull request #2145 from mlibrary/2144_jump_links
Add enhanced API for Blacklight::Icons handling cases for semantic and decorative icons fixes #2150
Merge pull request #2171 from projectblacklight/update-asset-generator
Move jquery3 requirement before rails-ujs require. Fixes #2002
Use jquery3 by default
Move facet_field_names to the configuration
Extract a spec for the facet_group template
Merge pull request #2137 from cdmo/collapsable-update
Update tested versions of ruby and rails
Prefer if over unless
Move all the solr modules under lib so zeitwerk can find them
Properly address modules
Handle text input rounding based on the number of search fields.
Suggested formatting changes for link_tos
jump link i18n changes, and uses link_to and bootstrap utility classes
Merge branch 'master' into 2144_jump_links
Updates describe to be more readable and changes behavior to add click listener on buttons with collapses attached (rather than every click).
update div to main
remove comma
add main landmark and translations
Removes window resize, this isn't needed for :headless_selenium and some code cleanup.
Adds behavior to force browsers to focus on button when a button is clicked.
Merge pull request #2128 from projectblacklight/remove-jquery-dep
Removes border-bottom for facet-field-heading. Adds button in specs for specificity.
Update app/views/catalog/_facet_layout.html.erb
Update app/assets/stylesheets/blacklight/_bootstrap_overrides.scss
Updates facet expand/collapse html and behavior
Merge pull request #2151 from labradford/arclight-841-add-aria-labels-to-sections
Add #size to pagination_methods to respond to the number of documents returned
Update comment as to why we have to keep this around
Remove complexity of entry_name in page_entries_info, Kaminari seems to have pushed this into the model
Adds in custom grouped response entry names for pagination information
Use fill based approach to styling icons over previous stroke
Fix whitespace issue in spec.
Bump the breakpoint that facets are in their "mobile"/collapsed view to the medium breakpoint.
add i18n keys for aria-labels
Merge pull request #2149 from labradford/arclight-841-add-aria-labels-to-sections
add aria-labels to section tags, fixes arclight issue 841
Remove jquery dependency from search_context.js
Suppress jshint warnings about semicolins
Default search bar autofocus to off
Provide a container to limit the spread of the stretch link
Add jump links to pages
Merge pull request #2138 from projectblacklight/responsive-sort-and-per-page-labels
Add Google Fi SMS mapping.
Add a new i18n key for the sort/per page labels that include HTML w/ bootstrap utility classes to remove unnecessary text at the smallest breakpoints.
Bump to v7.1.0 (#2135)
Bump to v7.1.0
Merge pull request #2132 from cdmo/2127-stretch-link
Adds a test for stretched anchor
Adds stretched-link class to make the anchor tag in the facet field heading stretch to fill available space on iOS especially
Remove jQuery dependecy from facet_load.js
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands