Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade blacklight to version 7.2.0 #87

Open
wants to merge 1 commit into
base: master
from

Conversation

@depfu
Copy link
Contributor

commented Oct 11, 2019

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ blacklight (7.1.0 → 7.2.0) · Repo

Release Notes

7.2.0

Commit History

New Features and improvements

#2118 Contribution guide updates
#2132, #2137 Significant improvements for accessibility and bug fixing to collapsible facets
#2138 Responsive sort and per page labels
#2128 Removes jquery dependency from search_context.js
#2169 Moves facet field names to configuration
#2171 New applications use jquery3 by default
#2145 Adds jump links to Blacklight
#2134 Updates how icons are styled in Blacklight to improve reuse downstream
#2139 Adds Google Fi mappings
#2149, #2151 Add aria-labels to section heading
#2157 Adds accessibility improvements and enhancements to the Blacklight::Icons class for svgs.
#2155 Update the breakpoint that facets use
#2140 Adds the ability to enable custom grouped response i18n "entries" for pagination

Bug Fixes

#2175 Adds sass-rails requirement for Rails 5
#2171 Updates the asset generator with an order that works for CSRF + rails-ujs + jquery3
#2165 Fixes an issue about input button rounding for fielded search

Updates/maintenance

#2148 Suppresses semi-colon warnings for jshint
#2167 Extracts a test for the facet_group template
#2162 Update location and addressing of modules. In preparation for Rails 6 and Zeitwerk

Upgrade Notes

Please note that #2137 provided some HTML changes where previous <a> elements were updated to <button> elements. This change was done to improve accessibility and usability and we are considering it an enhancements. Blacklight adopters should be aware of this as to look at local styling that may need to be modified.

#2134 updated how icons are styled in Blacklight. We are now using a fill based svg approach. This is consistent with how many icon libraries are now providing and styling their icons. It should also enable downstream users of Blacklight to more easily style icons.

#2145 Adds jump links to Blacklight, but also sets search bar autofocus to off. This can be reenabled but is left off for accessibility.

#2157 Adds enhanced accessibility features for svg icons used in Blacklight and downstream applications/engines.

Thank you to all of the contributors for this release!!! 🥇

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 59 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
@depfu depfu bot added the depfu label Oct 11, 2019
@ruebot

This comment has been minimized.

Copy link
Member

commented Oct 15, 2019

@​depfu rebase

@depfu depfu bot force-pushed the depfu/update/blacklight-7.2.0 branch from 72d97d3 to fe7304c Oct 15, 2019
@codecov

This comment has been minimized.

Copy link

commented Oct 15, 2019

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #87   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0dd43...fe7304c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.