@@ -17,13 +17,19 @@ Contributions to Sparkler should be made in the form of GitHub pull requests. Ea
##Pull Request Checklist
- Branch from the master branch and, if needed, rebase to the current master
- If an issue already exists in [issues page](https://github.com/USCDataScience/sparkler/issues)
to describe the change you are bringing into, great, remember the $ISSUENUM.
Otherwise, create an issue and get its $ISSUENUM.
- Branch from the master branch (ideally, with branch name 'SPKLR-$ISSUENUM') and, if needed, rebase to the current master
branch before submitting your pull request. If it doesn't merge cleanly with
master you may be asked to rebase your changes.
- Commits should be as small as possible, while ensuring that each commit is
correct independently (i.e., each commit should compile and pass tests).
- Commit messages shall start with "SPKLR-$ISSUENUM: ...."
- All the additional libraries, plugins you bring into the Sparkler have a license permissible to redistribute under Apache License 2.0. Ask us incase you are doubtful about a specific library.
- If your patch is not getting reviewed or you need a specific person to review it, you can @-reply a reviewer asking for a review in the pull request or a comment.
0 comments on commit
a776238