Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Flake8 F4 Tests to .travis.yml #974
Conversation
This comment has been minimized.
This comment has been minimized.
|
Another approach is to do smaller PRs... Like a PR that just adds F401 to .travis.yml and fixes the three instances of that. Another PR that adds F403 and fixes the two instance of that. Small moves. |
This comment has been minimized.
This comment has been minimized.
|
Should we progress this one or close it? |
This comment has been minimized.
This comment has been minimized.
|
I think we should progress. Checking for import errors can be helpful in the future, not just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
PatOnTheBack commentedJul 8, 2019
F4 tests check for import errors. Implements issue #973