Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCode & Doc clean-up #15
+126
−173
Conversation
adam3smith
added some commits
Feb 3, 2019
This comment has been minimized.
This comment has been minimized.
@greebie -- would you have time to look over this to make sure there's nothing dumb and/or things you strongly disagree with. I tested on both Windows & Linux and working nicely. |
greebie
requested changes
Feb 5, 2019
Thanks so much for the clean up Sebastian. Just a few minor fixes and then we're good to merge. |
R/archivr.R Outdated
if ((!(is.null(reply$detail))) && reply$detail == "Authentication credentials were not provided.") { | ||
stop("Please input your api key:\nUse 'set_api_key(API_KEY)'") | ||
} else if ((!(is.null(reply$error)))) { | ||
print(reply) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
adam3smith
Feb 5, 2019
Contributor
No, that actually printed on an error I got from perma.cc and was quite helpful.
This comment has been minimized.
This comment has been minimized.
R/archivr.R Outdated
arc_url_df <- archiv.fromText("path_to_file") | ||
``` | ||
|
||
To allow for pre-processing of URLs before archiving, `archivr` also provides access to the funcitons used to extract URLs from a webpage (`extract_urls_from_webpage("URL")`), from a files (`extract_urls_from_text("filepath")`) (tested for .docx, markdown, and pdf), and from any supported text file in a folder (`extract_urls_from_folder("filepath")`) |
This comment has been minimized.
This comment has been minimized.
adam3smith
merged commit 61462ca
into
master
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
adam3smith commentedFeb 3, 2019
stop
for API-key related errors