Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: cppduals: a nestable vectorized templated dual number library for C++11 #1487
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @StewMH and @mdavezac, it looks like you're currently assigned as the reviewers for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
If you have any questions or problems, please tell me. |
This comment has been minimized.
This comment has been minimized.
Hi @tesch1, I tried compiling this with GCC 7.3 and got this error:
I think you need a workaround here. See e.g. opencv/opencv#8080 for a similar issue. I didn't have any luck compiling it with Clang on Ubuntu either, so far. Also, it's Apache-licensed but you have MPL-licensed files: |
This comment has been minimized.
This comment has been minimized.
Hi, Thanks for reviewing! Ah yeah, the "older gcc missing avx primitive". Just checked in an update/workaround. Does it compile for you now? Also, did you run into the same error(s) under clang, or was there something else? Regarding the licenses, yes, there are some files that were modified from Eigen, so retain the Eigen license. These are only included with |
This comment has been minimized.
This comment has been minimized.
@tesch1, have you considered dual licensing the non-eigen parts with MPL as well as Apache? That way, users can pick a format where the whole product is covered under a single license. |
This comment has been minimized.
This comment has been minimized.
Oh yes, that's a great idea. I'll do that. I picked Apache+LLVM because libc++ uses it, and wanted to be broadly compatible with that, but dual-licensing is even better. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Hi, I have got past the missing avx primitive with GCC. Now the compilation runs for a while but fails with an ICE probably related to out-of-memory, at least on my VM. I can try a more powerful bare-metal machine, the VM only has 2G of RAM. Cheers, |
This comment has been minimized.
This comment has been minimized.
An issue has been filed in the original repo. @StewMH, I think I clicked on your checkboxes rather than mine at some point... I tried to undo the damage, but I do apologized if I made a mess of things |
This comment has been minimized.
This comment has been minimized.
@tesch1 - please let us know when you have worked on the issues in https://gitlab.com/tesch1/cppduals/issues/4 |
This comment has been minimized.
This comment has been minimized.
Thanks for the great comments. I'm currently on the road without a
computer for a couple weeks, and will let you know when the questions have
been addressed.
…On Thu, Jun 13, 2019 at 12:10 PM Daniel S. Katz ***@***.***> wrote:
@tesch1 <https://github.com/tesch1> - please let us know when you have
worked on the issues in https://gitlab.com/tesch1/cppduals/issues/4
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1487?email_source=notifications&email_token=AACOYL5FL5AK7UHHXBIPDA3P2J5OPA5CNFSM4HTUNXL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXUMLGA#issuecomment-501794200>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACOYLY4YXGMRU6GAGHUJ63P2J5OPANCNFSM4HTUNXLQ>
.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reminder set for @tesch1 in 2 weeks |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf from branch paper-3 @StewMH - did you ever get it to compile? Some Eigen constructs can be quite demanding on compiler memory, especially in newer (> 3.3.7) versions. I've updated https://gitlab.com/tesch1/cppduals/issues/4 and merged changes into the master branch (which is currently building). Regarding licensing, have changed everything to MPL-2 for simplicity's sake. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@danielskatz It would appear that whedon does not correctly use custom branches from gitlab when generating pdfs (or I did the syntax wrong above?) |
This comment has been minimized.
This comment has been minimized.
What didn't work? It looks like whedon generated a PDF. Is it not from the right branch? |
This comment has been minimized.
This comment has been minimized.
It is not from the right branch. |
This comment has been minimized.
This comment has been minimized.
Thanks - once the submission is accepted (hopefully in another 10 min or so), the DOI for the JOSS article will be shown here. You can certainly add this to the zenodo metadata. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There seem to be some issue in a couple of bib entries - can you merge https://gitlab.com/tesch1/cppduals/merge_requests/18 which I think should fix them? |
This comment has been minimized.
This comment has been minimized.
Merged |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1087, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@tesch1 - you can see the DOI above (https://doi.org/10.21105/joss.01487). It's not quite working for me yet, which could be a backlog in registering new DOIs, or it could be due to a server in my location - Once it works, I will close this issue and we will be done. |
This comment has been minimized.
This comment has been minimized.
Ah, now the DOI resolves, but I don't yet see https://www.theoj.org/joss-papers/joss.01487/10.21105.joss.01487.pdf working. |
This comment has been minimized.
This comment has been minimized.
I second that, Thanks gentlemen!! Also thank you, @danielskatz ! |
This comment has been minimized.
This comment has been minimized.
@tesch - does https://www.theoj.org/joss-papers/joss.01487/10.21105.joss.01487.pdf work for you? |
This comment has been minimized.
This comment has been minimized.
@danielskatz nope, 404 |
This comment has been minimized.
This comment has been minimized.
@arfon, any thoughts on this? |
This comment has been minimized.
This comment has been minimized.
Congrats, @tesch1! |
This comment has been minimized.
This comment has been minimized.
Looks like there's an issue with GitHub Pages right now: https://www.githubstatus.com/incidents/42hkbtl63nmn |
This comment has been minimized.
This comment has been minimized.
OK, looks like the PDF URL is resolving now. |
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedJun 5, 2019
•
edited
Submitting author: @tesch1 (Michael Tesch)
Repository: https://gitlab.com/tesch1/cppduals
Version: v0.1.2
Editor: @danielskatz
Reviewer: @StewMH, @mdavezac
Archive: 10.5281/zenodo.3528307
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@StewMH & @mdavezac, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
Review checklist for @StewMH
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @mdavezac
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?