Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd keep and discard by http status. #347
Conversation
ruebot
requested a review
from ianmilligan1
Aug 17, 2019
ruebot
force-pushed the
issue-315
branch
from
b1fc950
to
77b9990
Aug 17, 2019
ruebot
force-pushed the
issue-315
branch
from
77b9990
to
5a4263a
Aug 17, 2019
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Aug 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
========================================
Coverage ? 71.7%
========================================
Files ? 38
Lines ? 1428
Branches ? 331
========================================
Hits ? 1024
Misses ? 245
Partials ? 159 |
ianmilligan1
approved these changes
Aug 17, 2019
|
Looks good to me (unit tests + TravisCI turned green, plus I kicked the tires around locally out of habit). |
ianmilligan1
merged commit 018527a
into
master
Aug 17, 2019
ianmilligan1
deleted the
issue-315
branch
Aug 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedAug 17, 2019
GitHub issue(s): #315
What does this Pull Request do?
How should this be tested?