Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesFix perma_cc bug #24 #26
Conversation
This comment has been minimized.
This comment has been minimized.
Not sure why it failed AppVeyor - something about pdftools not running properly. |
This comment has been minimized.
This comment has been minimized.
Sorry this took a while, but this doesn't work for me and it almost looks like you reverted your fix in the second commit above? Output:
|
This comment has been minimized.
This comment has been minimized.
Also, as you suspect,
|
This comment has been minimized.
This comment has been minimized.
@greebie if you do work on this on Monday, could you take another look at this? |
This comment has been minimized.
This comment has been minimized.
Hi Sebastian - I think this is working as it is now. It requires that you use set_folder_id("id of selected folder") to work. Don't forget to delete my useless links in your account please! |
greebie commentedMar 10, 2019
The main issue was not as I suspected, but it was that the if--else was not being properly satisfied when the "NOT A URL" was being sent to the API.
NOTE: the latest commit may create another error for QDR's account, because the QDR account has multiple root rows as per #25 . If it does create a problem, I think it would be best to fix that issue in this PR too.