Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEmerald Journals #2036
Labels
Comments
This comment has been minimized.
This comment has been minimized.
|
Announcement: https://www.emeraldgrouppublishing.com/about/news/?id=8571 They've switched away from the Atypon platform we did support |
adam3smith
added a commit
to adam3smith/translators
that referenced
this issue
Oct 24, 2019
Closes zotero#2036
This comment has been minimized.
This comment has been minimized.
|
Okay. I also see the old things in our code: $ grep -i emerald *.js
Atypon Journals.js: } else if (url.includes('www.emeraldinsight.com')) {
Atypon Journals.js: //for Emerald, improve author's lastname and firstname
Atypon Journals.js: //for Emerald, get rid of the "null" that they add at the end of every title:
Atypon Journals.js: if (url.includes("www.emeraldinsight.com")){
Atypon Journals.js: "url": "http://www.emeraldinsight.com/toc/sajgbr/2/2",
Atypon Journals.js: "url": "http://www.emeraldinsight.com/doi/full/10.1108/SAJGBR-10-2012-0120",
Atypon Journals.js: "libraryCatalog": "emeraldinsight.com (Atypon)",
Atypon Journals.js: "url": "http://www.emeraldinsight.com/doi/full/10.1108/SAJGBR-10-2012-0120",
Baidu Scholar.js: "url": "http://www.emeraldinsight.com/doi/full/10.1108/07419051111154758",(I already filtered out a false positive result in We should clean up this code then also as Emerald is not using Atypon anymore, but first I will continue the review for your new translator. |
This comment has been minimized.
This comment has been minimized.
|
Note: your translator uses RIS and not EM now, but it looks good. |
This comment has been minimized.
This comment has been minimized.
|
Reopening, because cleaning up Atypon translator is still a todo. |
zuphilip
added a commit
to zuphilip/translators
that referenced
this issue
Nov 3, 2019
This finally closes zotero#2036.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
They changed their site -- it think we used to cover this with one of the default translators, but doesn't look like that's currently working. EM imports nicely but without PDF
https://www.emerald.com/insight/content/doi/10.1108/IJRDM-08-2017-0180/full/html