Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Springer Books + Springer Link #2031
Conversation
One small request. Everything else looks good to merge |
@@ -148,6 +148,11 @@ function scrapeBook(doc, url) { | |||
var edition = ZU.xpathText(doc, '//dt[text()="Edition Number" or text()="Auflage"]/following-sibling::dd[1]'); | |||
if (edition && edition !== "1") item.edition = edition; | |||
|
|||
var doi = ZU.xpathText(doc, '//dt[text()="DOI"]/following-sibling::dd[1]'); | |||
if (doi) { | |||
item.extra = "DOI: " + doi; |
This comment has been minimized.
This comment has been minimized.
adam3smith
Oct 20, 2019
Collaborator
Since embedded metadata can write unknown fields to Extra as welll, could we add a test for content in Extra here to make sure we're not overwriting anything?
Along these line
if (item.extra) {
if (!item.extra.includes("DOI") {
item.extra += "\nDOI: " + doi;
}
else {
item.extra = "DOI: " + doi;
}
This comment has been minimized.
This comment has been minimized.
@@ -405,6 +404,7 @@ var degenerateImportFieldMap = { | |||
CA: "unsupported/Caption", | |||
CR: "rights", | |||
CT: "title", | |||
CY: "place", |
This comment has been minimized.
This comment has been minimized.
adam3smith
Oct 20, 2019
Collaborator
Actually, this doesn't seem right, either. CY
is already included for place, just not for conference papers see
Line 287 in 72c9771
This comment has been minimized.
This comment has been minimized.
zuphilip
Oct 20, 2019
Author
Collaborator
Not exporting is okay, but why should we not import it if it is there? (There are similar cases in the RIS translator already e.g. for NV.)
Example:
TY - CONF
AU - Rusch, Anja
AU - Wille, Rudolf
ED - Bock, Hans-Hermann
ED - Polasek, Wolfgang
PY - 1996
DA - 1996//
TI - Knowledge Spaces and Formal Concept Analysis
BT - Data Analysis and Information Systems
SP - 427
EP - 436
PB - Springer Berlin Heidelberg
CY - Berlin, Heidelberg
AB - J.-P. Doignon and J.-C. Falmagne have introduced a formal notion of knowledge space to develop a scientific approach to the assessment of knowledge. They define a knowledge space as a (finite) set Q of questions together with a collection K, of subsets of Q representing different knowledge states; in addition, they assume that K is closed under set unions. The theory of knowledge spaces can be effectively connected with formal concept analysis. The connection is established by the definition of a knowledge context as a triple (P, Q, I) where P is a finite set of persons, Q is a finite set of questions, and I is a binary relation between P and Q such that plq means: the person p cannot solve the question q. For each knowledge context there is a corresponding knowledge space which consists of the complements of all intents of this context; conversely, each knowledge space can be derived in this way. Via the described connection, methods of formal concept analysis can be successfully applied to the theory of knowledge spaces. In particular, the attribute exploration as a method of conceptual knowledge acquisition yields a new approach for building knowledge spaces.
SN - 978-3-642-80098-6
ID - 10.1007/978-3-642-80098-6_36
ER -
Alternatively, I can also make a fix only in Springer Link translator, but I don't see any reason not to import this RIS field for any source if it is there. Let me know if you disagree and I am missing something.
This comment has been minimized.
This comment has been minimized.
adam3smith
Oct 20, 2019
Collaborator
I agree with import in the absence of CI
, yes -- I only checked quickly, but we do already have code that looks like it'd handle the same scenario:
Line 1036 in 72c9771
Might make sense to check if we can then take this out or alternatively use this version instead of the hard to understand degenerateImport fields? (but no strong preference either way; just don't want duplicate code)
This comment has been minimized.
This comment has been minimized.
zuphilip
Oct 20, 2019
Author
Collaborator
Okay, I will look into this more closely at a later point and also check the code you have found.
This comment has been minimized.
This comment has been minimized.
zuphilip
Oct 21, 2019
Author
Collaborator
Uff, that is a little complicated... The code you found is only considered for RIS from ProCite. When I try to take this out of this special part, then the type is not yet defined. But I cannot replace CY with C1 always, as this would destroy the cases for books as an example.
Thus, I will continue with the degenerateImport fields which I find easier to work with.
This comment has been minimized.
This comment has been minimized.
Let me know @adam3smith whether you can have a look at the new version. |
This comment has been minimized.
This comment has been minimized.
All good from my end. Please go ahead and squash as you see fit and merge. |
- the standard map already handle CY as place for all cases but for conferencePapers - conferencePaper should instead use C1 as place - however there are cases (ProCite export, RIS from Springer) where also for conferencePaper CY is used for the place - this is now handled directly in the degenerateMap
This comment has been minimized.
This comment has been minimized.
Okay, I rebased the commits and fixed the commit messages. Thanks for the hint. Merging now. |
zuphilip commentedOct 19, 2019
No description provided.