Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd volume info again in HeinOnline.js #2040
+45
−33
Conversation
This comment has been minimized.
This comment has been minimized.
|
(Linting issues are not yet solved.) |
This comment has been minimized.
This comment has been minimized.
|
That's great -- do you still want to fix linting? Otherwise you can go ahead and merge. |
This comment has been minimized.
This comment has been minimized.
|
Here we go with fixing the linting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedOct 26, 2019
This solves #2038.