Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLA: Add container-author to other-contributors #4147

Merged
merged 2 commits into from Oct 11, 2019
+25 −11

Conversation

@bwiernik
Copy link
Contributor

commented Jun 14, 2019

From https://forums.zotero.org/discussion/comment/333958/#Comment_333958

How should we address the logic for L140?
@bwiernik
MLA: Add container-author to other-contributors
Loading status checks…
5223569
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 14, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 14, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association.csl (modified style; unchanged output for sample items)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)
“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, doi:10.1038/s41597-019-0031-8.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213.
@stale

This comment has been minimized.

Sign in to view
Copy link

commented Jul 14, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.
@stale stale bot added the waiting label Jul 14, 2019
@bwiernik

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jul 14, 2019

@adam3smith Any changes you wanted here?
@stale stale bot removed the waiting label Jul 14, 2019
@stale

This comment has been minimized.

Sign in to view
Copy link

commented Aug 13, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.
@stale stale bot added the waiting label Aug 13, 2019
@bwiernik

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Aug 13, 2019

@adam3smith Any changes you wanted here? How should we address the logic for L140?
@stale stale bot removed the waiting label Aug 13, 2019
@stale

This comment has been minimized.

Sign in to view
Copy link

commented Sep 12, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.
@stale stale bot added the waiting label Sep 12, 2019
@stale stale bot closed this Sep 26, 2019
@adam3smith adam3smith reopened this Sep 26, 2019
@stale stale bot removed the waiting label Sep 26, 2019
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 26, 2019

Sorry this is taking so long
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Sep 26, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association.csl (modified style; unchanged output for sample items)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)
“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, doi:10.1038/s41597-019-0031-8.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213.
@adam3smith
address volume logic
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
99fb513
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 10, 2019

sorry this took forever. See if this makes sense to you, please.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

commented Oct 10, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association.csl (modified style; unchanged output for sample items)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)
“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, doi:10.1038/s41597-019-0031-8.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism : Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213.
@bwiernik

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Oct 10, 2019

That looks good to me
@adam3smith adam3smith merged commit 50e1d07 into citation-style-language:master Oct 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 11, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bwiernik @csl-bot @adam3smith
You can’t perform that action at this time.