New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated issued in chicago (author-date) #3638

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@bwiernik
Contributor

bwiernik commented Aug 8, 2018

issued is rendered twice for webpage and post-weblog. This change aligns Chicago (author-date) with Chicago (note) and (fullnote), where these lines have already been removed.

Reported https://forums.zotero.org/discussion/73102/duplicated-date#latest

Remove duplicated issued in chicago (author-date)
`issued` is rendered twice for webpage and post-weblog. This change aligns Chicago (author-date) with Chicago (note) and (fullnote).

Reported https://forums.zotero.org/discussion/73102/duplicated-date#latest
@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Aug 8, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

csl-bot commented Aug 8, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Aug 8, 2018

😃 Your submission passed all our automated tests.

csl-bot commented Aug 8, 2018

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Aug 8, 2018

Member

It's a little trickier than this: Chicago Manual wants the full date, including year, repeated in the 17th edition. This used to be just month and day in the 16th edition.

E.g.
Google. 2016. “Privacy Policy.” Privacy & Terms. Last modified March 25, 2016. http://www.google.com/policies/privacy/.

(This has "last modified" but the rule extends generally). Since we can't actually test for the presence of day/month, I'm not sure how to get this right across the board.

Member

adam3smith commented Aug 8, 2018

It's a little trickier than this: Chicago Manual wants the full date, including year, repeated in the 17th edition. This used to be just month and day in the 16th edition.

E.g.
Google. 2016. “Privacy Policy.” Privacy & Terms. Last modified March 25, 2016. http://www.google.com/policies/privacy/.

(This has "last modified" but the rule extends generally). Since we can't actually test for the presence of day/month, I'm not sure how to get this right across the board.

@bwiernik

This comment has been minimized.

Show comment
Hide comment
@bwiernik

bwiernik Aug 8, 2018

Contributor

Oh, okay, so the style is correct then, but just weird when there is no author or non-year date parts.

Contributor

bwiernik commented Aug 8, 2018

Oh, okay, so the style is correct then, but just weird when there is no author or non-year date parts.

@bwiernik bwiernik closed this Aug 8, 2018

@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Aug 8, 2018

Member

I think the ability to test for date parts comes up frequently enough to consider that for the next "big" CSL release. Should be easy enough, I imagine.

Member

adam3smith commented Aug 8, 2018

I think the ability to test for date parts comes up frequently enough to consider that for the next "big" CSL release. Should be easy enough, I imagine.

@bwiernik

This comment has been minimized.

Show comment
Hide comment
@bwiernik

bwiernik Aug 8, 2018

Contributor

I agree. That would be helpful in a variety of ways.

Contributor

bwiernik commented Aug 8, 2018

I agree. That would be helpful in a variety of ways.

@bwiernik bwiernik referenced this pull request Aug 8, 2018

Open

Testing for date-parts #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment