Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRewrite Wikisource translator #1050
+334
−46
Conversation
adam3smith
reviewed
Apr 22, 2016
| @@ -80,11 +180,9 @@ var testCases = [ | |||
| "creatorType": "author" | |||
| } | |||
| ], | |||
| "abstractNote": "\"Amazing Grace\" (c. 1772) is one of the most well-known Christian hymns. The words thereof are part of the Olney Hymns that the author had worked on, with William Cowper and other hymnodists.\nThe text was first set to the tune NEW BRITAIN in William Walker's Southern Harmony, 1835.", | |||
This comment has been minimized.
This comment has been minimized.
adam3smith
Apr 22, 2016
Collaborator
no good way to get the abstract? I thought that was nice to have.
This comment has been minimized.
This comment has been minimized.
zuphilip
Apr 22, 2016
Author
Collaborator
-
I think it might rather be an exception that there is something like an abstract in wikisource. I am not even sure if the note here is really an abstract or maybe more like a description of this famous text.
-
Previously, this was extracted from the node
//div[contains(@class, "header_notes")]which will also result in "Listen to this text (help | file info or download)" for https://en.wikisource.org/wiki/Alice's_Adventures_in_Wonderland_%281866%29/Chapter_2
This comment has been minimized.
This comment has been minimized.
adam3smith
merged commit 22f4644
into
zotero:master
Apr 23, 2016
This comment has been minimized.
This comment has been minimized.
|
This looks great, thanks! |
This was referenced Apr 23, 2016
Closed
zuphilip
deleted the
zuphilip:wikisource
branch
Apr 23, 2016
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedApr 15, 2016
This should superseeds #1034 and #1048.