Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[J-Stage.js]: Fix cases when no pdf is available #1125
Conversation
This comment has been minimized.
This comment has been minimized.
|
( I noticed some potential problems for this translator by looking at the website https://repo.zotero.org/errors ) |
adam3smith
reviewed
Aug 27, 2016
J-Stage.js
Outdated
| tags[i] = ZU.trimInternal(tags[i]); | ||
| } | ||
| tags = tags.replace(/Keywords:/, "").split(/\s*,\s*/); | ||
| for (var i in tags) { |
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 27, 2016
Collaborator
might as well do this properly with (i = 0; i<tags.length; i++)
adam3smith
reviewed
Aug 27, 2016
J-Stage.js
Outdated
| @@ -94,29 +101,35 @@ function scrape(doc, url) { | |||
| translator.setHandler("itemDone", function (obj, item) { | |||
| if (abs) item.abstractNote = abs; | |||
| if (tags) item.tags = tags; | |||
| for (i in item.creators) { | |||
| for (var i in item.creators) { | |||
This comment has been minimized.
This comment has been minimized.
adam3smith
reviewed
Aug 27, 2016
J-Stage.js
Outdated
| item.attachments = [{ | ||
| url: item.url, | ||
| item.attachments.push({ | ||
| url: url, | ||
| title: "Jstage - Snapshot", |
This comment has been minimized.
This comment has been minimized.
adam3smith
Aug 27, 2016
Collaborator
Let's use J-Stage here and l. 129 for the PDF, in line with the library catalog and translator label.
This comment has been minimized.
This comment has been minimized.
|
a couple of comments, should be quick. thanks! |
This comment has been minimized.
This comment has been minimized.
|
Please have a look at the new version. |
adam3smith
merged commit 055fa20
into
zotero:master
Aug 27, 2016
This comment has been minimized.
This comment has been minimized.
|
great, thanks |
zuphilip
deleted the
zuphilip:jstage
branch
Aug 27, 2016
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedAug 27, 2016
Also fixing the extraction of the abstract and updating the
structure of the translator in general. Add a new test case.