Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMore fixes #1138
+345
−476
Conversation
zuphilip
added some commits
Sep 7, 2016
zuphilip
reviewed
Sep 8, 2016
| @@ -1223,38 +1184,6 @@ var testCases = [ | |||
| }, | |||
| { | |||
| "type": "web", | |||
| "url": "http://books.upress.virginia.edu/title/4539", | |||
This comment has been minimized.
This comment has been minimized.
zuphilip
reviewed
Sep 8, 2016
| @@ -807,51 +809,6 @@ var exports = { | |||
| var testCases = [ | |||
| { | |||
| "type": "web", | |||
| "url": "http://acontracorriente.chass.ncsu.edu/index.php/acontracorriente/article/view/174", | |||
This comment has been minimized.
This comment has been minimized.
adam3smith
added some commits
Sep 9, 2016
This comment has been minimized.
This comment has been minimized.
|
Great -- take a quick look to make sure you're OK with my two changes (this really is very handy, glad you mentioned it!) |
This comment has been minimized.
This comment has been minimized.
|
Yes, your changes are fine and improve the PR. Thank you. Looks good for me. |
adam3smith
merged commit 1eaf013
into
zotero:master
Sep 9, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks (I did see and check the Beck update) |
zuphilip
deleted the
zuphilip:more-fixes
branch
Sep 9, 2016
This comment has been minimized.
This comment has been minimized.
|
Thank you. The collaboration feature in PR on github is handy. I think this way we can work much more together on a feature, which is nice. (Yes, beck-online is just restricted to subscribers and on-campus networks, i.e. the tests on your side will still fail.) |
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zuphilip commentedSep 8, 2016
Here is B and one of C (because I noticed some potential problems in errors).