Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and update magazines.russ.ru.js #1210

Merged
merged 2 commits into from Dec 31, 2016

Conversation

@zuphilip
Copy link
Collaborator

commented Dec 30, 2016

CC @avram

@avram

avram approved these changes Dec 30, 2016

Copy link
Contributor

left a comment

Thanks for fixing this up! Why are you renaming the translator? The name of the catalog is unchanged.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 31, 2016

@avram I renamed the file and the label, because they should match to each other (and this is also what Scaffold will do now automatically). However, a file named Журнальный зал.js could cause a lot of troubles in my setting (command line, git). Moreover, it is hard with respect to ordering (does "Ж" come before or after "Z"?). This experience you also have currently in Scaffold when trying to open translators which are ordered alphabetically. Finally, it seems also that we more stick to ASCII only file names, e.g. Musee du Louvre.js.

@avram

This comment has been minimized.

Copy link
Contributor

commented Dec 31, 2016

My only concern is that that leaves us with a suboptimal value for the catalog field. I suppose that could still be set manually to the proper name.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 31, 2016

Changed libraryCatalog to Журнальный зал.

@avram Please have a look at the new version.

@adam3smith adam3smith merged commit 145a7b4 into zotero:master Dec 31, 2016

@zuphilip zuphilip deleted the zuphilip:magazines-russ branch Dec 31, 2016

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Rename and update magazines.russ.ru.js (zotero#1210)
good call on forcing the library catalog rename. Thanks both!

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Rename and update magazines.russ.ru.js (zotero#1210)
good call on forcing the library catalog rename. Thanks both!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.